Skip to content

Make date/time converter TCK tests locale-data tolerant#2188

Open
robertpatrick wants to merge 1 commit into
jakartaee:masterfrom
robertpatrick:tck-date-time-jdk25-master
Open

Make date/time converter TCK tests locale-data tolerant#2188
robertpatrick wants to merge 1 commit into
jakartaee:masterfrom
robertpatrick:tck-date-time-jdk25-master

Conversation

@robertpatrick

@robertpatrick robertpatrick commented Jun 19, 2026

Copy link
Copy Markdown

Fixes #2187

This updates the Faces TCK converter tests to avoid brittle expectations when running on newer JDKs with updated locale data.

Changes:

  • Generate the Dutch localized date/time input and expected output values with DateTimeFormatter, using the same locale and format styles exercised by the tests.
  • Replace legacy PST timezone usage in the old DateTimeConverter test with America/Los_Angeles.

This fixes JDK 25 failures in:

  • Issue4087IT#testJavaTimeTypes
  • Issue4110IT#testLocalDateTime

Verification:

  • Ran the two affected converter tests against WebLogic with JDK 25 using the updated TCK artifacts.
  • Result: 2 tests run, 0 failures, 0 errors, 0 skipped.

@dmatej dmatej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Dutch locale preinstalled on all standard environments? I remember times when ie. Solaris had just a few and user had to install more manually.

It is just a question, I agree to merge this + cherrypick to older versions. I have seen failures of these tests many times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Faces TCK hard-codes JDK 21 Dutch localized LocalDateTime text and fails on JDK 25

3 participants