Fix broken CLI when we add new API versions#105
Merged
olivhoenen merged 3 commits intoJul 20, 2026
Conversation
Yannicked
requested review from
SimonPinches,
maarten-ic,
olivhoenen and
prasad-sawantdesai
as code owners
July 14, 2026 12:16
olivhoenen
approved these changes
Jul 16, 2026
Contributor
There was a problem hiding this comment.
Looks fine to me, but as discussed with @prasad-sawantdesai and in #103, we will need to explicitly tell about API versioning rules in the dev documentation.
Collaborator
Author
|
Add decorators to API calls in client |
Collaborator
Author
|
@prasad-sawantdesai Using this PR in #70 you could add @versioned_method('v1.3')
@try_request
def get_simulation_data(...)and update the |
Contributor
Thanks. Updated #70 |
Contributor
|
@Yannicked Do you understand why it failed? #70 $ simdb remote pr-70 test
Error: 'get_api_version' is not supported by the negotiated API version 'v1.3'. It requires one of: v1.2.simdb.cfg [remote "pr-70"]
url = http://10.154.84.240:5101/
default = True |
Contributor
It worked with these changes 8964e06 $ simdb remote pr-70 test
Remote is valid (remote API version: 1.3) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI previously selected the latest API version advertised by the server (even when it's unsupported by the client), so deploying a new API version would immediately switch all existing clients onto it (and break them).
This PR will select the highest version supported by both sides.