status: Add dual-stack mgmt address support and integration coverage by moogzy · Pull Request #3532 · ipspace/netlab

moogzy · 2026-06-27T08:57:08Z

Summary:

Add dual-stack management visibility in netlab status output with integration coverage for that behaviour.

Addresses #3358

// Previous behaviour

vscode ➜ /workspaces/netlab/tests (dev) $ netlab status
Lab default in /workspaces/netlab/tests
  status:      started
  topology:    platform-integration/cli/12-status-mgmt-dual-stack.yml
  provider(s): clab

┏━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ node ┃ device ┃ image              ┃ mgmt IPv4      ┃ connection ┃ provider ┃ VM/container ┃ status       ┃
┡━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ x    │ linux  │ python:3.13-alpine │ 192.168.121.11 │ docker     │ clab     │ clab-cli-x   │ Up 8 seconds │
└──────┴────────┴────────────────────┴────────────────┴────────────┴──────────┴──────────────┴──────────────┘

// New behaviour - backwards compatible with default v4 address only

vscode ➜ /workspaces/netlab/tests (dev) $ ../netlab status
Lab default in /workspaces/netlab/tests
  status:      started
  topology:    platform-integration/cli/13-status-mgmt-v4-only.yml
  provider(s): clab

┏━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ node ┃ device ┃ image              ┃ mgmt           ┃ connection ┃ provider ┃ VM/container ┃ status        ┃
┡━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ x    │ linux  │ python:3.13-alpine │ 192.168.121.21 │ docker     │ clab     │ clab-cli-x   │ Up 10 seconds │
└──────┴────────┴────────────────────┴────────────────┴────────────┴──────────┴──────────────┴───────────────┘

// New behaviour - dual-stack support

vscode ➜ /workspaces/netlab/tests (dev) $ ../netlab status
Lab default in /workspaces/netlab/tests
  status:      started
  topology:    platform-integration/cli/12-status-mgmt-dual-stack.yml
  provider(s): clab

┏━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ node ┃ device ┃ image              ┃ mgmt             ┃ connection ┃ provider ┃ VM/container ┃ status        ┃
┡━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ x    │ linux  │ python:3.13-alpine │ 192.168.121.11   │ docker     │ clab     │ clab-cli-x   │ Up 17 seconds │
│      │        │                    │ 2001:db8:121::11 │            │          │              │               │
└──────┴────────┴────────────────────┴──────────────────┴────────────┴──────────┴──────────────┴───────────────┘

Changes:

Show IPv6 management address on a new line under IPv4 in status mgmt column.
Add platform integration test for v4-only and dual-stack status output.
Fix integration validation script warning by initializing error counter and quoting file paths.

Copilot

Pull request overview

This PR enhances the netlab status CLI output to improve management IP visibility by showing dual-stack (IPv4 + IPv6) management addressing, and adds platform integration tests to cover the new status output behavior.

Changes:

Update netlab status to display IPv6 management addresses (when present) alongside IPv4 in the mgmt column.
Add platform integration CLI tests for IPv4-only and dual-stack mgmt status output.
Fix tests/check-integration-tests.sh robustness by initializing the error counter and quoting file paths.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`netsim/cli/status.py`	Adds IPv6 mgmt capture and renders mgmt as multi-line output in the status table.
`tests/platform-integration/cli/12-status-mgmt-dual-stack.yml`	New integration test ensuring status output contains both IPv4 and IPv6 mgmt addresses.
`tests/platform-integration/cli/13-status-mgmt-v4-only.yml`	New integration test ensuring status output contains the IPv4 mgmt address for IPv4-only nodes.
`tests/check-integration-tests.sh`	Initializes `err_cnt` and quotes `$file` to avoid validation script warnings/word-splitting issues.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Fixes ipspace#3358 What changed: - Render node management addresses in netlab status with IPv6 on a new line under IPv4 in the mgmt column. - Add platform integration test tests/platform-integration/cli/12-status-mgmt.yml to validate dual-stack mgmt output. - Harden tests/check-integration-tests.sh by initializing err_cnt and quoting topology path arguments. Why: - The status output did not clearly present dual-stack management addresses and could be ambiguous/truncated in narrow output. - Integration validation emitted a noisy shell warning when err_cnt was unset.

ipspace · 2026-06-29T15:18:51Z

      'mgmt':   n_data.mgmt.ipv4
    }
    node_stat = ls.nodes[n_name]
+    if n_data.get('mgmt.ipv6'):


This is perfectly fine, but if you want, you could rewrite this whole thing into a loop over a dict mapping node data into status data.

ipspace

Nice job. The "do not set mgmt on tools" should be reverted because it changes JSON data. Other than that, it's just a few minor quirks/nits.

Thank you!

ipspace · 2026-06-29T15:19:03Z

    wk_state = p_status[n_provider].get(wk_name,get_empty_box())
    ls.nodes[t_name] = {
      'device': '(tool)',
+      'mgmt': '',


I don't think this is needed

ipspace · 2026-06-29T15:19:13Z

 def show_lab_nodes(ls: Box, topology: Box) -> None:
  rows = []
-  heading = [ 'node', 'device', 'image', 'mgmt IPv4', 'connection', 'provider', 'VM/container', 'status']
+  heading = [ 'node', 'device', 'image', 'mgmt', 'connection', 'provider', 'VM/container', 'status']


How about "mgmt IP"?

ipspace · 2026-06-29T15:20:14Z


  for n_name,n_data in ls.nodes.items():
-    row = [ n_name, n_data.device, n_data.image, n_data.get('mgmt',''),
+    mgmt = f'{n_data.mgmt}\n{n_data.mgmt6}' if n_data.get('mgmt6') else n_data.get('mgmt')


If you leave the old n_data.get('mgmt','') as the fallback expression, then you don't need to set 'mgmt' for tools.

ipspace · 2026-06-29T15:22:13Z

@@ -0,0 +1,26 @@
+---
+message: |


I love that you implemented the integration tests, but I'd put v4 only test first (just swap the sequence numbers) and use a topology that combines libvirt, clab, and a tool, so that we test whether status works over all three objects.

ipspace · 2026-06-29T15:23:38Z


 ┏━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
-┃ node    ┃ device ┃ image                       ┃ mgmt IPv4       ┃ connection ┃ provider ┃ VM/container   ┃ status       ┃
+┃ node    ┃ device ┃ image                       ┃ mgmt            ┃ connection ┃ provider ┃ VM/container   ┃ status       ┃


This would have to change if we go for "mgmt IP" (below)

Copilot AI review requested due to automatic review settings June 27, 2026 08:57

Copilot started reviewing on behalf of moogzy June 27, 2026 08:57 View session

Copilot AI reviewed Jun 27, 2026

View reviewed changes

Comment thread netsim/cli/status.py

Comment thread netsim/cli/status.py

moogzy requested a review from Copilot June 27, 2026 09:08

Copilot started reviewing on behalf of moogzy June 27, 2026 09:09 View session

moogzy changed the title ~~status: improve dual-stack mgmt display and integration coverage~~ status: Add dual-stack mgmt address support and integration coverage Jun 27, 2026

moogzy mentioned this pull request Jun 27, 2026

[ENHANCEMENT] netlab status should display the IPv6 management address if it is enabled #3358

Open

Copilot AI reviewed Jun 27, 2026

View reviewed changes

Comment thread tests/check-integration-tests.sh

Comment thread netsim/cli/status.py

moogzy force-pushed the enhancement/add_dualstack_mgmt_address_support_to_status branch from 521a636 to 464919e Compare June 27, 2026 09:32

ipspace reviewed Jun 29, 2026

View reviewed changes

ipspace requested changes Jun 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

status: Add dual-stack mgmt address support and integration coverage#3532

status: Add dual-stack mgmt address support and integration coverage#3532
moogzy wants to merge 1 commit into
ipspace:devfrom
moogzy:enhancement/add_dualstack_mgmt_address_support_to_status

moogzy commented Jun 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

ipspace Jun 29, 2026

Uh oh!

ipspace left a comment

Uh oh!

ipspace Jun 29, 2026

Uh oh!

ipspace Jun 29, 2026

Uh oh!

ipspace Jun 29, 2026

Uh oh!

ipspace Jun 29, 2026

Uh oh!

Uh oh!

ipspace Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,26 @@
		---
		message: \|

Conversation

moogzy commented Jun 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

ipspace Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

ipspace left a comment

Choose a reason for hiding this comment

Uh oh!

ipspace Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

ipspace Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

ipspace Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

ipspace Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ipspace Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants