Improve <NOTOPEN> error reporting (#462)#985
Open
isc-pbarton wants to merge 1 commit into
Open
Conversation
isc-pbarton
commented
Jul 23, 2026
isc-pbarton
commented
Jul 23, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
+ Coverage 49.14% 49.38% +0.24%
==========================================
Files 22 22
Lines 3315 3335 +20
==========================================
+ Hits 1629 1647 +18
- Misses 1686 1688 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
isc-pbarton
commented
Jul 23, 2026
isc-pbarton
force-pushed
the
diagnose-notopen-squashed
branch
from
July 23, 2026 20:13
fa81986 to
4f1634f
Compare
isc-pbarton
marked this pull request as ready for review
July 23, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #462
Resolves #981
NOTOPEN errors running git commands mask an underlying OS error. We now report that OS error and suggest the root cause in the error message: either the git executable cannot be found, or we don't have permissions to run it.
Testing
Unit tests provide good coverage on Unix. I did some manual testing on Windows:
do ##class(SourceControl.Git.Utils).Clone("blah")throws the same error.Checklist
mainbranch rebased or merged.git-webui/srchave matching changes ingit-webui/release)