Skip to content

Improve <NOTOPEN> error reporting (#462)#985

Open
isc-pbarton wants to merge 1 commit into
mainfrom
diagnose-notopen-squashed
Open

Improve <NOTOPEN> error reporting (#462)#985
isc-pbarton wants to merge 1 commit into
mainfrom
diagnose-notopen-squashed

Conversation

@isc-pbarton

@isc-pbarton isc-pbarton commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Description

Resolves #462
Resolves #981

NOTOPEN errors running git commands mask an underlying OS error. We now report that OS error and suggest the root cause in the error message: either the git executable cannot be found, or we don't have permissions to run it.

Testing

Unit tests provide good coverage on Unix. I did some manual testing on Windows:

  • Git executable is not on the path and not configured on the settings page. The Settings page shows an error message like "git was not found. Make sure git is installed and on the IRIS user's PATH, or set an absolute path to the git executable on the Settings page." Running a git command like do ##class(SourceControl.Git.Utils).Clone("blah") throws the same error.
  • Git executable is configured to be a file that can't actually be executed, like an empty file. Both cases display a different error message "git could not be launched (<193> %1 is not a valid Win32 application.)"

Checklist

  • This branch has the latest changes from the main branch rebased or merged.
  • Web UI has been built (any changes in git-webui/src have matching changes in git-webui/release)
  • CHANGELOG.md entry added if appropriate.
  • [N/A] Documentation has been/will be updated

Comment thread cls/SourceControl/Git/Utils.cls Outdated
Comment thread csp/gitprojectsettings.csp Outdated
@codecov-commenter

codecov-commenter commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.38%. Comparing base (c12184c) to head (4f1634f).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 78.26% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
+ Coverage   49.14%   49.38%   +0.24%     
==========================================
  Files          22       22              
  Lines        3315     3335      +20     
==========================================
+ Hits         1629     1647      +18     
- Misses       1686     1688       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread README.md Outdated
@isc-pbarton
isc-pbarton force-pushed the diagnose-notopen-squashed branch from fa81986 to 4f1634f Compare July 23, 2026 20:13
@isc-pbarton
isc-pbarton marked this pull request as ready for review July 23, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants