refactor: add EventSink support to overall utilization collector#387
Merged
Conversation
The overall collector used event.Save() directly, which meant callers could not redirect its events to a custom sink — unlike the other four host metric collectors (cpu, memory, disk, network) which all embed event.EventSink and expose a NewWithSink constructor. Add the EventSink embedded field, a NewWithSink constructor, and switch Collect() from event.Save() to m.Save(). This follows the exact same pattern already established by the other host metric packages, enabling the inspect package to inject its own FileMetricSink.
medcl
approved these changes
Jun 30, 2026
hardy-dev-infinilabs
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overall collector used event.Save() directly, which meant callers could not redirect its events to a custom sink — unlike the other four host metric collectors (cpu, memory, disk, network) which all embed event.EventSink and expose a NewWithSink constructor.
Add the EventSink embedded field, a NewWithSink constructor, and switch Collect() from event.Save() to m.Save(). This follows the exact same pattern already established by the other host metric packages, enabling the inspect package to inject its own FileMetricSink.
Standards checklist