Fix event drop by fetching 3 pages with ETag optimization#317
Open
emalaj-seq wants to merge 2 commits into
Open
Fix event drop by fetching 3 pages with ETag optimization#317emalaj-seq wants to merge 2 commits into
emalaj-seq wants to merge 2 commits into
Conversation
Fixes igrigorik#310 The previous commit f1f4200 changed PAGE_LIMIT from 500 to 100 (per GitHub API requirements) but only fetched a single page, causing an ~80% drop in captured events (from ~500 to ~100 per cycle). This fix: - Fetches 5 pages in parallel (up to 500 events, matching original capacity) - Adds ETag-based conditional GET requests to minimize API usage - Skips polling cycles when page 1 returns 304 Not Modified - Automatically scales: only fetches pages that contain data - Updates Gemfile to use https:// instead of git:// protocol Results: - Restores original 500 event capture capacity - Efficient API usage through ETag optimization - No more missed events during normal GitHub activity levels Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
emalaj-seq
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@igrigorik
Fixes #310
The previous commit f1f4200 changed PAGE_LIMIT from 500 to 100 (per GitHub API requirements) but only fetched a single page, causing an ~80% drop in captured events (from ~500 to ~100 per cycle).
This fix:
Results: