Align default server port with Laravel#422
Merged
Merged
Conversation
Change the primary HTTP server default port from the Hyperf-era 9501 value to Laravel's 8000 convention.\n\nRename the default application server environment variables from HTTP_SERVER_HOST and HTTP_SERVER_PORT to SERVER_HOST and SERVER_PORT. The unprefixed names now describe the primary application server, while future secondary listeners can use explicit prefixes such as REVERB_SERVER_* or METRICS_SERVER_*.\n\nUpdate the low-level Port fallback to 8000 as well so ad hoc server port instances match the published default configuration.
Move live test fixtures away from the old 9501 default and onto the new 8000 baseline.\n\nUse 8001 for command override examples so the tests continue to prove that serve --port mutates only the HTTP server entry.\n\nRefresh route-port and socket tests that used 9501 as arbitrary sample data so live tests no longer keep teaching the removed default.
Update the current Boost documentation to describe the new 8000 default server port and SERVER_HOST / SERVER_PORT environment variables.\n\nRefresh nginx proxy examples, starter-kit and installation URLs, lifecycle copy, benchmark snippets, and Testbench serve examples so user-facing 0.4 docs consistently show the Laravel-aligned default.\n\nHistorical 0.3 docs, archived tests, and dated planning notes are intentionally left unchanged.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (93)
📝 WalkthroughWalkthroughThe default Hypervel HTTP server port is changed from 9501 to 8000 across config defaults, the Port class, and documentation, with override examples updated from 9502 to 8001. The ChangesDefault HTTP server port update
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)Not applicable — this change is a repetitive default-value substitution across config, tests, and docs without new control flow or multi-component interactions. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR aligns Hypervel's default HTTP server port with Laravel's convention by changing the default from
Confidence Score: 5/5Safe to merge — all changes are mechanical port/env-var renames applied consistently across config, source, tests, and docs. The diff is a coherent rename of a default value and two env variable names. The config default, the Port fallback, all test fixtures, and all current documentation are updated in lockstep. Integration-test engine ports and historical 0.3 docs are intentionally left unchanged, which is correct. A grep for stale references in src/ and tests/ found none. No logic, security surface, or runtime behavior changed. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Document Laravel-aligned server defaults" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Hypervel still carried the old Hyperf-era HTTP server default of
9501. For 0.4, the public surface is much closer to Laravel, and the development server should feel familiar when someone reaches for the default address.Laravel's
servecommand defaults to port8000, withSERVER_HOST/SERVER_PORTavailable as environment-backed defaults. This PR brings Hypervel's primary application server in line with that convention.Changes
9501to8000.HTTP_SERVER_HOST/HTTP_SERVER_PORTtoSERVER_HOST/SERVER_PORT.Hypervel\Server\Portfallback to8000so ad hoc port instances match the published default.8000,8001for override examples, and the new env variable names.I intentionally left historical material alone:
docs/0.3,docs/plans,_archive, and the engine integration test ports such as19501/19502/29501are not part of the public application server default.Why the env rename
SERVER_HOSTandSERVER_PORTnow describe the primary application server. If Hypervel grows additional listeners later, those can use explicit prefixes for their own domains, like Reverb already does withREVERB_SERVER_HOST/REVERB_SERVER_PORT.This keeps the common path Laravel-familiar without preventing more specific server configuration names where they are actually needed.
Verification
Ran
composer fixfrom the components repo root.git diff --check: passedI also searched the live surface for stale references:
HTTP_SERVER_HOST/HTTP_SERVER_PORTreferences remain insrc,tests, current docs,.github, orbin.9501/9502references remain in those areas..githubworkflows only referenceTEST_SERVER_HOSTfor opt-in engine/reverb integration servers, which is unrelated to the application server default.Summary by CodeRabbit
Documentation
8000and8001.Bug Fixes
8000.