fix: publish the permission snapshot refresh sweep#8
Merged
Conversation
The sweep landed in #7, but the branch's two commits were collapsed by an amend and main ended up with a chore: subject. release-please does not bump on chore, so no release was cut and the fix -- players losing all permissions ten minutes after joining -- is sitting on main unpublished. Carries the correct subject so it ships, and adds the missing README documenting the env contract, including the new PERMISSIONS_REFRESH_INTERVAL_SECONDS knob. Release-As: 0.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The refresh sweep merged in #7 — but that PR's two commits got collapsed by an amend, so
mainended up with achore(minestom):subject. release-please does not bump onchore, so no release was cut and the fix is sitting on main unpublished.The fix is the one where every player silently loses all permissions ten minutes after joining, so it needs to actually ship.
What
Release-As: 0.4.0— the versioncontainers#182andminestom-lobby#25are already pinned to.PERMISSIONS_REFRESH_INTERVAL_SECONDS.No code change — the code is already on main.