[Crane: crane-migration-python-to-go-full-apm-cli-rewrite]#119
[Crane: crane-migration-python-to-go-full-apm-cli-rewrite]#119github-actions[bot] wants to merge 2 commits into
Conversation
…81: fix 6 failing functional/state-diff contract tests Changes: - cmd_lockfile.go: add readConfigKey and removeConfigKey helpers - cmd_config.go: config get reads persisted value from config file; config unset removes key from config file - cmd_mcp.go: mcp list reads MCPDeps from apm.yml instead of returning empty stub - cmd_marketplace.go: marketplace remove deletes entry from apm.yml; marketplace validate rejects unregistered name - cmd_runtime.go: runtime remove deletes runtime key from config file Fixes 6 functional/state-diff gate regressions introduced after PR #116 hardened the completion gates: TestGoCutoverRealFunctionalAndStateDiffContracts now 26/26. Run: https://github.com/githubnext/apm/actions/runs/27318507620 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Migration Benchmark Results
Migration CLI BenchmarkIncludes fixture-backed commands that must read, write, execute, or fail against real project state. The installed-project fixture contains apm.yml, apm.lock.yaml, apm_modules packages, local .apm primitives, target directories, deployed prompt files, and sample source files. Max allowed Go/Python median ratio:
Workloads
|
|
Warning The [Crane] Iteration 82 -- CI Fix: All Parity GatesStatus: [+] Accepted (CI pending) Root CausePR #116 hardened the completion gates after iter 81. Three separate failures were blocking the Python-vs-Go Parity Gate: A)
B) C) Fixes
Local VerificationAlso merged |
[bot] This PR is maintained by Crane. Each accepted iteration adds a commit to this branch.
Migration: Python 3.10+ (CPython, Click, Rich) -> Go (native binary)
Strategy: greenfield
Migration Issue: #78
State File:
crane-migration-python-to-go-full-apm-cli-rewrite.mdIteration 81 -- Stale-Completion Reset + Functional/State-Diff Contract Fixes
Status: Accepted -- pending CI confirmation
Previous
Completed: truewas stale (PR #117 merged, crane branch deleted). After reset, the current verification contract found 6 functional/state-diff gate regressions introduced when PR #116 hardened the completion gates. All 6 are fixed in this iteration.Changes:
cmd/apm/cmd_lockfile.go: addreadConfigKeyandremoveConfigKeyhelperscmd/apm/cmd_config.go:config getreads persisted value from config file;config unsetremoves key from filecmd/apm/cmd_mcp.go:mcp listreads MCPDeps fromapm.ymlinstead of returning a stubcmd/apm/cmd_marketplace.go:marketplace removedeletes entry fromapm.yml;marketplace validate NAMErejects unregistered namescmd/apm/cmd_runtime.go:runtime removedeletes runtime key from config file