Skip to content

Ci sandbox#96

Draft
aviv1ron1 wants to merge 50 commits into
generative-computing:mainfrom
aviv1ron1:ci-sandbox
Draft

Ci sandbox#96
aviv1ron1 wants to merge 50 commits into
generative-computing:mainfrom
aviv1ron1:ci-sandbox

Conversation

@aviv1ron1

@aviv1ron1 aviv1ron1 commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

aviv1ron1 added 20 commits July 9, 2026 15:22
@aviv1ron1
Apply ruff format and lint autofixes across the codebase
e1a92ce 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Add CI/CD: pre-commit hooks, GitHub Actions, and blocking ruff gate
24f1bad 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Point .git-blame-ignore-revs at the reformat commit
5c27167 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
improve documentation for DCO, add auto sign off hook
5409437 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
fix tests to run on github actions
384d5b2 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
remove uv from pre commit execution documentation
c07d4c9 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
fix pre commit order
584437b 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
run pre commit hooks as post commit validations
6ac9465 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
update plan
d589514 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
remove composer tests from ci
28acc8b 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
remove hf tests
991c35d 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
remove hf tests from ci
1fc4cda 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
remove hf tests from ci
4103aec 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
bad spacing, unsused var
b97ddac 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
unused var
1dcf0c0 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
unused var
9157fbf 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
unused import
44e5b63 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
unused import
3b4c4d3 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Harden validate_links against malformed pyproject.toml
ea864f7 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Merge branch 'cicd-combined' into ci-sandbox
d5b83b8 
Signed-off-by: aviv ron <rona@il.ibm.com>
@codecov-commenter

codecov-commenter commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0.67797% with 293 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ranite_switch/composer/reporting/compose_report.py 0.00% 60 Missing ⚠️
src/granite_switch/composer/arch.py 0.00% 23 Missing ⚠️
src/granite_switch/composer/adapter_loader.py 0.00% 18 Missing ⚠️
src/granite_switch/hf/modeling_granite_switch.py 0.00% 16 Missing ⚠️
src/granite_switch/composer/weight_transfer.py 0.00% 15 Missing ⚠️
src/granite_switch/hf/core/lora.py 0.00% 15 Missing ⚠️
.../granite_switch/composer/compose_granite_switch.py 0.00% 13 Missing ⚠️
src/granite_switch/vllm/core/lora_kernel_meta.py 0.00% 13 Missing ⚠️
src/granite_switch/composer/adapter_discovery.py 0.00% 12 Missing ⚠️
...rc/granite_switch/composer/reporting/model_card.py 0.00% 11 Missing ⚠️
... and 19 more

📢 Thoughts on this report? Let us know!

aviv1ron1 added 9 commits July 12, 2026 12:45
@aviv1ron1
broken toml
adb28b1 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Order config validators before ruff in pre-commit
0458e5a 
Ruff loads its config from pyproject.toml, so a malformed pyproject.toml
makes ruff abort with a parser error instead of the clean check-toml
message. Running check-toml/check-yaml first (with fail_fast) ensures
syntax errors are reported by the dedicated validator, consistently
between local commits and CI's --all-files run.

Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Merge branch 'cicd-combined' into ci-sandbox
a67c3f3 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
fix broken toml
63ae6dd 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
broken yaml
15bc8dd 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
fix yaml
ae516d9 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
no spdx
8f36a47 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
no spdx
d96f0c1 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
no dco
67f674d 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
test dco no signoff
41be410 
Signed-off-by: aviv ron <rona@il.ibm.com>
aviv1ron1 added 8 commits July 12, 2026 18:11
@aviv1ron1
broken link
09594a1 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
fix deadlink
3fabcba 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
big files
6304316 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Enforce large-file check in CI via --enforce-all
7af9691 
check-added-large-files only inspects staged additions, so on CI's clean
checkout (nothing staged) it was a no-op. --enforce-all makes it check all
files under pre-commit run --all-files. uv.lock (~2.3 MB) is excluded as an
intentionally large lockfile.

Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Merge branch 'cicd-combined' into ci-sandbox
6eec814 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
remove test big.bin
2884ca5 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
big files
be3534b 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
remove test big.bin
7ef535d 
Signed-off-by: aviv ron <rona@il.ibm.com>
aviv1ron1 added 2 commits July 13, 2026 13:18
@aviv1ron1
test conflict
6761399 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
test commit conflicts
067be23 
Signed-off-by: aviv ron <rona@il.ibm.com>

Signed-off-by: Aviv Ron <rona@il.ibm.com>
Signed-off-by: aviv ron <rona@il.ibm.com>
aviv1ron1 added 10 commits July 13, 2026 13:25
@aviv1ron1
Update test section in README.md
93243a1 
Signed-off-by: Aviv Ron <rona@il.ibm.com>
@aviv1ron1
test conflict
740f615 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
test conflict
f8ffd83 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Run merge-conflict check in CI via --assume-in-merge
c292762 
check-merge-conflict returns early unless a merge is in progress, so on
CI's clean checkout it was a no-op. --assume-in-merge makes it always
scan, letting pre-commit run --all-files catch committed conflict markers.

Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Merge branch 'cicd-combined' into ci-sandbox
2bd78b8 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Document whole-tree CI enforcement for large-file and merge-conflict …
3bbb162 
…hooks

Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
Merge branch 'cicd-combined' into ci-sandbox
cd6132a 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
fix conflict
6bc5b53 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
test case
d6c0c0d 
Signed-off-by: aviv ron <rona@il.ibm.com>
@aviv1ron1
remove case test
b6c5ae0 
Signed-off-by: aviv ron <rona@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonpibm antonpibm Awaiting requested review from antonpibm antonpibm will be requested when the pull request is marked ready for review antonpibm is a code owner
@freunda freunda Awaiting requested review from freunda freunda will be requested when the pull request is marked ready for review freunda is a code owner
@yairallouche yairallouche Awaiting requested review from yairallouche yairallouche will be requested when the pull request is marked ready for review yairallouche is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aviv1ron1 @codecov-commenter