Escape \${CMAKE_INSTALL_PREFIX} instead of using $<INSTALL_PREFIX>#1990
Draft
Rangi42 wants to merge 1 commit into
Draft
Escape \${CMAKE_INSTALL_PREFIX} instead of using $<INSTALL_PREFIX>#1990Rangi42 wants to merge 1 commit into
\${CMAKE_INSTALL_PREFIX} instead of using $<INSTALL_PREFIX>#1990Rangi42 wants to merge 1 commit into
Conversation
The latter requires CMake 3.27, despite only being necessary when cross-compiling for Windows MinGW on Linux.
Rangi42
added
bug
Member
|
This won't work if the install prefix isn't specified at compile time. |
Contributor
Author
Ugh. I really hope you have a solution that does work then, because right now we're relying on a 3.27 feature while claiming to support 3.24. I'm trying to find a simple solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1985
To do: make sure that building this on Windows 7 with CMake 3.24 actually works.