feat: support decker devnet artifacts#562
Open
julio4 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Extends --builder.playground devnet auto-configuration to support decker’s artifacts layout in addition to the legacy builder-playground layout, selecting configuration based on detected directory markers.
Changes:
- Add layout detection in playground auto-config, supporting both legacy (docker-compose.yaml parsing) and decker (fixed ports/peer-id) layouts.
- Change
--builder.playground’s bare-flag behavior to auto-resolve to either./.decker/runtime/artifacts(if present) or the legacy default directory. - Add unit tests covering layout detection and decker vs legacy option derivation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/op-rbuilder/src/args/playground.rs | Detect decker vs legacy artifact layouts; apply fixed decker constants; add tests. |
| crates/op-rbuilder/src/args/op.rs | Implement bare --builder.playground auto-directory resolution with decker-first behavior. |
| crates/op-rbuilder/src/args/mod.rs | Update CLI docs to describe the new auto-resolution and layout detection behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+152
to
+158
| fn resolve_playground_auto_dir_from(cwd: &Path) -> Result<PathBuf> { | ||
| let decker_default = cwd.join(DECKER_DEFAULT_DIR); | ||
| if decker_default.exists() { | ||
| return Ok(decker_default); | ||
| } | ||
| expand_shell(LEGACY_DEFAULT_DIR) | ||
| } |
Comment on lines
123
to
128
| if !path.exists() { | ||
| return Err(eyre!( | ||
| "Playground data directory {} does not exist", | ||
| path.display() | ||
| )); | ||
| } |
| @@ -94,7 +97,7 @@ pub struct OpRbuilderArgs { | |||
| #[arg( | |||
akundaz
approved these changes
Jul 23, 2026
akundaz
left a comment
akundaz
left a comment
Contributor
There was a problem hiding this comment.
lgtm, but what is decker?
the ai also seems to have caught a couple of typos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
--builder.playgroundto recognize decker runtime/artifacts/ layout.For now keeping builder-playground support as legacy option but can be removed later.