Energyflow: fix invisible expand icon in dark mode#31026
Merged
Conversation
The shopicon arrowdropdown SVG ships a hardcoded inline fill:#000 that overrides the currentColor base rule, so the expand triangle stayed black and vanished on dark backgrounds. Replace it with the existing MaterialIcon Dropdown component, which uses fill=currentColor and is already used for the same collapsible pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #31006
The expand triangles in the energy flow disappeared in dark mode. The shopicon arrowdropdown SVG ships a hardcoded inline
fill:#000that overrides the shopicons basefill: currentColorrule, so the icon stayed black and vanished on dark backgrounds.fill="currentColor"), already used for the same collapsible pattern.