Minor typing fixes for dwarf#661
Merged
Merged
Conversation
Fixes: 12e9636 ("Fix a bunch of other ruff check issues") Signed-off-by: Philipp Hahn <phahn-oss@avm.de>
Harmonize both CFIEntry and FDE to expect bytes for augmentation_bytes; drop None alternative. Signed-off-by: Philipp Hahn <phahn-oss@avm.de>
eliben
reviewed
Jun 3, 2026
Instead of using dwarf_assert(False, mgs) directly raise DWARFError(msg). Signed-off-by: Philipp Hahn <phahn-oss@avm.de>
pmhahn
force-pushed
the
typing-dwarf-fixes
branch
from
June 3, 2026 20:03
df53f2e to
b598da5
Compare
Owner
|
Thank you! Apparently the |
eliben
approved these changes
Jun 4, 2026
Owner
|
EM102 checks are not enabled in this repo -- I'm just using the defaults; do you have all ruff checks enabled? |
Contributor
Author
Sometime yes, but not this time. I did the initial conversion from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👍 to use
ruff, but sadly you introduces one minor but by converting an lambda into an untyped function.I also had (another) look on how to remove the duplication of
{dwarf,elf}_assert()vs.asserts required for typing. While doing that I stumbled over 3dwarf_assert(False, …), which should be replaced by anraise DWARFError()to make the error more obvious (and to reduce the length of the backtrace).I also noticed, that
class FDE(CFIEntry)has a slightly different type-annotation than its super-class, which I have fixed.