readelf: Always add one blank between columns#658
Merged
eliben merged 1 commit intoMay 26, 2026
Conversation
$ test/external_tools/readelf --debug-dump=frames-interp test/testfiles_for_dwarfdump/dwarf_v5ops.so.elf | grep 2d335
000000000002d335 rsp+10256 c-56 c-48 c-40 c-32 c-24 c-16 c-8
^
$ scripts/readelf.py --debug-dump=frames-interp test/testfiles_for_dwarfdump/dwarf_v5ops.so.elf | grep 2d335 # broken
000000000002d335 rsp+10256c-56 c-48 c-40 c-32 c-24 c-16 c-8
^^
$ scripts/readelf.py --debug-dump=frames-interp test/testfiles_for_dwarfdump/dwarf_v5ops.so.elf | grep 2d335 # fixed
000000000002d335 rsp+10256 c-56 c-48 c-40 c-32 c-24 c-16 c-8
^
Signed-off-by: Philipp Hahn <phahn-oss@avm.de>
eliben
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While converting test tests to use pytest I stumbled over one difference, where
readelf.pydoes not print at least one column separator:Insert at least one blank between each column; reduce the following column width by one character.