Skip to content

Silent amplitude logger#20

Merged
ivpusic merged 2 commits into
mainfrom
silent_amplitude_logger
Mar 9, 2026
Merged

Silent amplitude logger#20
ivpusic merged 2 commits into
mainfrom
silent_amplitude_logger

Conversation

@ivpusic

@ivpusic ivpusic commented Mar 9, 2026

Copy link
Copy Markdown
Member

Currently it shows debug statements, in release build

@cursor

cursor Bot commented Mar 9, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Behavior change is limited to telemetry client logging and developer build/run targets, with minimal impact on core CLI functionality.

Overview
Suppresses noisy Amplitude SDK logging in non-dev CLI builds by wiring a silentLogger into the Amplitude client config unless CLIVersion is empty/dev.

Updates the makefile to split dune-cli into a fast dune-cli-quick build (no lint), add a run target that executes the locally built binary with ARGS, and keep build/dune-cli running lint by default.

Written by Cursor Bugbot for commit 87090ed. Configure here.

@coderabbitai

coderabbitai Bot commented Mar 9, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c5b0f86e-07af-4528-bea0-4d228406fcb5

📥 Commits

Reviewing files that changed from the base of the PR and between 87090ed and 10352b6.

📒 Files selected for processing (1)
  • makefile

📝 Walkthrough

Walkthrough

Makefile: updated PHONY targets, removed install and dune-cli blocks, replaced lint dependency mapping and added a run target that executes the CLI via go run. tracking/tracking.go: added dev-version detection and a no-op silentLogger to suppress Amplitude SDK logging in non-release builds.

Changes

Cohort / File(s) Summary
Build Configuration
makefile
Updated PHONY targets to include run and removed install. Removed the dune-cli target block and adjusted lint/build mappings; added run target that executes go run -ldflags '$(LDFLAGS)' ./cmd $(ARGS).
Logging & Observability
tracking/tracking.go
Added isDevVersion helper and conditional logic to set Amplitude SDK logger to a silentLogger (no-op) when CLI version is non-release/dev; introduced silentLogger implementing logger methods as no-ops.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Silent amplitude logger' clearly summarizes the main change: suppressing amplitude SDK logger output in release builds.
Description check ✅ Passed The description 'Currently it shows debug statements, in release build' is related to the changeset and identifies the problem being addressed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread makefile Outdated
Comment thread makefile Outdated
Comment thread makefile Outdated
@ivpusic ivpusic merged commit d402cf8 into main Mar 9, 2026
3 checks passed
@ivpusic ivpusic deleted the silent_amplitude_logger branch March 23, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants