Metrics command group#468
Merged
Merged
Conversation
…t passing is non-working, and when hard-coded through, uncovers a panic in metric buffer search. Assisted-by: Claude Opus 4.8
KodrAus
reviewed
Jun 8, 2026
KodrAus
reviewed
Jun 8, 2026
| public async Task<MetricDefinition[]> SearchMetricsAsync( | ||
| [Description("The maximum number of metric definitions to return.")] | ||
| [Range(1, 1000)] | ||
| int limit, |
Member
There was a problem hiding this comment.
nit: These are kind of hard to read when condensed like this with lots of attributes. Some whitespace around the the parameters would help.
Member
Author
There was a problem hiding this comment.
Will hit this one on a future pass 👍
KodrAus
reviewed
Jun 8, 2026
KodrAus
reviewed
Jun 8, 2026
Member
Author
|
The added metrics skill is minimal, and doesn't include query shapes for exponential histograms. I'll PR those when I have the information at hand. |
KodrAus
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uncovers a panic in the current Seq 2026.1 preview, so may not build/be mergeable until we've pushed up a fix for that.
Adds basic CLI commands for interacting with metrics, and matching MCP tools.
The MCP endpoints follow largely the same pattern. We'll need a new skill to cover metrics, which I'll kick off and add to the PR shortly. Some iteration/testing is going to be needed, it's not clear just yet how well agents will go using metrics this way.
The commands, command tests, and MCP tool are written by hand. I used Claude to port the command tests over to cover the MCP endpoints.