fix(models): derive PDP batch schema configs from institution schemas#247
Open
vishpillai123 wants to merge 3 commits into
Open
fix(models): derive PDP batch schema configs from institution schemas#247vishpillai123 wants to merge 3 commits into
vishpillai123 wants to merge 3 commits into
Conversation
When model.schema_configs is null, PDP inference now builds a default required COURSE+STUDENT (etc.) batch rule from inst.schemas instead of 500ing. Explicit model configs still take precedence. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
When multiple dev bundle jobs match a PDP or legacy inference pipeline substring, resolve to [dev dev_cloudrun_sa] if present; otherwise use the first sorted match instead of failing the inference request. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model.schema_configsis null, PDP inference derives a default batch composition rule frominst.schemas(required one-of-each for input types like COURSE and STUDENT).schema_configsstill take precedence when present.Fixes the Jackson State class of failures after create-model was simplified to name-only (#238): models created without
schema_configscan run inference as long as the institution has standard input schemas configured.Test plan
pytest src/webapp/routers/models_test.pyschema_configs(e.g. Jackson State)schema_configssetMade with Cursor