Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds a safety guard to prevent creating or loading databases without use_system_metadata_collection on buckets whose bootstrap metadata already resides in _system._mobile, avoiding cluster split-brain config states.
Changes:
- Reject DB create/load when the bucket bootstrap target is
_system._mobilebut the DB config is not opted into the system metadata collection. - Introduce
BucketBootstrapTargetIsSystemMobileonBootstrapConnectionand implement it for Couchbase and Rosmar backends. - Add regression tests covering both “migrated” and “opted-in-from-start” bucket scenarios.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| rest/server_context.go | Enforces opt-in requirement during DB load/add when bucket bootstrap target is _system._mobile. |
| rest/admin_api.go | Enforces opt-in requirement during DB creation before persisting config. |
| base/bootstrap.go | Extends BootstrapConnection with a method to resolve current bucket bootstrap target. |
| base/rosmar_cluster.go | Probes/caches registry location and exposes BucketBootstrapTargetIsSystemMobile for Rosmar. |
| db/database_error.go | Adds a new database error code/message for the opt-in-required case. |
| rest/metadatamigrationtest/metadata_migration_test.go | Adds tests ensuring non-opt-in DBs are rejected when bucket bootstrap metadata is in _system._mobile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5511
Stop loading/creating a db is bootstrap level migration is done for the bucket but the db is opted out of mobile collection
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests