Support sharded Parquet file querying and conversion#7610
Open
SungJin1212 wants to merge 3 commits into
Open
Conversation
dosubot
Bot
added
component/store-gateway
go
SungJin1212
force-pushed
the
parquet-shard
branch
2 times, most recently
from
635d72e to
524e917
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
parquet-shard
branch
from
524e917 to
2b79cb9
Compare
yeya24
reviewed
Jun 11, 2026
| errGroup.SetLimit(p.concurrency) | ||
| for i := range shardBlockIDs { | ||
| errGroup.Go(func() error { | ||
| blk, err := p.newParquetBlock(egCtx, shardBlockIDs[i], shardIDs[i], bucketOpener, bucketOpener, p.chunksDecoder, p.rowRangesCache, noopQuota, noopQuota, noopQuota) |
Contributor
There was a problem hiding this comment.
I haven't looked at how this parquet sharding works for quite some time now... The sharding is to shard at columns... So do we really need to open all shards here? Or based on sharding do we know if we can only open 1 file is enough?
Member
Author
There was a problem hiding this comment.
We can't tell which shard holds a matching series.. So we need to open all shard files. (the converter mark only stores the shard count, with no per-shard label metadata)
| # splits a block into more parquet shards for better read parallelization. | ||
| # Default is unlimited (single shard). | ||
| # CLI flag: -parquet-converter.num-row-groups | ||
| [num_row_groups: <int> | default = 2147483647] |
Contributor
There was a problem hiding this comment.
We should have an integration test with sharding enabled?
Member
Author
There was a problem hiding this comment.
I added an e2e test.
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports for querying sharded Parquet files within a bucket store and enables the conversion of sharded Parquet files.
Benchmark Results
Currently, the concurrency is hard-coded as 4.
Which issue(s) this PR fixes:
Fixes #7176 #7174
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags