feat(billing): implement promo code functionality#657
Open
Dobrunia wants to merge 7 commits into
Open
Conversation
Contributor
|
Thanks for adding a description — the PR is now marked as Ready for Review. |
neSpecc
reviewed
Jun 12, 2026
Comment on lines
+64
to
+88
| promoCodeId?: string; | ||
| /** | ||
| * Applied promo code value | ||
| */ | ||
| promoCodeValue?: string; | ||
| /** | ||
| * Promo benefit type | ||
| */ | ||
| benefitType?: 'grant_plan' | 'percent_discount' | 'amount_discount' | 'fixed_price'; | ||
| /** | ||
| * Plan price before promo | ||
| */ | ||
| originalAmount?: number; | ||
| /** | ||
| * Final price after promo | ||
| */ | ||
| finalAmount?: number; | ||
| /** | ||
| * Actual discount amount | ||
| */ | ||
| discountAmount?: number; | ||
| /** | ||
| * UTM parameters captured when promo was applied | ||
| */ | ||
| promoUtm?: Utm; |
Member
There was a problem hiding this comment.
lets wrap it with "promo" property. Also, maybe promo.id is enough?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(billing): implement promo code functionality and update related types