Retry commit-only ref updates when head moves#11
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6\n\nThis handles the race where a commit-only run creates a commit, then PATCHing refs/heads/main fails because someone else moved the branch in between.\n\nI wrapped that ref update in a targeted retry path:\n- if GitHub returns a 422 ref-update conflict, treePush reruns once against the latest branch head\n- the second run rebuilds the commit off the current base instead of forcing the old SHA\n- non-422 errors still fail immediately\n\nVerification I ran locally:\n- node --check github-tree-push-module/index.js\n- a targeted Node harness that simulates a 422 on the first ref update and confirms treePush retries exactly once and rebuilds the commit\n- eslint on the changed file with prettier rule disabled (to avoid unrelated formatting drift in this repo)