Extend api copilot#22
Merged
Merged
Conversation
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR adjusts build/install OS branching in the Makefile, adds an additional (newer) GitHub API version header constant, and updates the sample program to demonstrate a different API call (page views metrics).
Changes:
- Simplified Darwin vs non-Darwin shared library targets and aligned install/uninstall library paths to
$(LIBDIR). - Added a second API version header macro and corrected an error-message allocation size in
gh_client_code_of_conduct_get_by_key. - Switched
example.cto execute the page-views metrics call instead of the repositories list example.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Makefile | Simplifies OS conditionals and fixes install/uninstall library removal paths. |
| github.c | Adds an extra API-version macro and tweaks an error-message allocation size. |
| example.c | Changes which API call the example runs (page views metrics). |
| docs/.keep | Placeholder file to keep the docs directory present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.