resolve miminal issues

[briandowns]

No description provided.

[Copilot]

Pull request overview

This PR makes small cleanup and safety-focused updates to the C GitHub API client header and implementation, including API surface adjustments and more defensive parsing/NULL handling.

Changes:

• Adjusts the public header layout/API (include guard positioning, removes/renames some exported items).
• Adds defensive checks and memory initialization in the client implementation.
• Refactors pagination Link header parsing to avoid modifying const input.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
github.h	Public header/API adjustments (include guard placement, removed constants/types, stargazers function name fix).
github.c	Adds curl handle reset in macro, adds NULL checks, and updates Link/rate-limit header parsing and response initialization.

Comments suppressed due to low confidence (2)

github.c:170

• parse_link_header() can segfault and also mis-parse the rel value: rel_end is computed via strchr(rel_start, '"') even when rel_start is NULL, and it currently finds the opening quote in rel="..." rather than the closing quote. This can crash on unexpected Link header formats and will truncate rel incorrectly.

        char *url_start = strchr(token, '<');
        char *url_end = strchr(token, '>');
        char *rel_start = strstr(token, "rel=\"");
        char *rel_end = strchr(rel_start, '\"');

github.c:218

• header_cb() parses buffer with strtok/strsep, but libcurl does not guarantee the header callback buffer is NUL-terminated. This can read past total_size and cause undefined behavior. Copy the header chunk into a local NUL-terminated buffer before tokenizing.

    size_t total_size = size * nmemb;
    gh_client_response_t *response = (gh_client_response_t*)userdata;

    char *line = strtok(buffer, "\r\n");
    char *key = strsep(&line, ":");

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.