Widen assets.size to BIGINT#1429
Open
genematx wants to merge 2 commits into
Open
Conversation
The `assets.size` column was defined as `Integer` (int32), so registering a single file larger than ~2.1 GB failed on PostgreSQL with `value out of int32 range` during INSERT. Change the ORM column to `BigInteger` and add an alembic migration that runs `ALTER TABLE assets ALTER COLUMN size TYPE BIGINT` on PostgreSQL. SQLite is unaffected because its `INTEGER` affinity already stores 64-bit values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
assets.sizecolumn was defined asInteger(int32), so registering a single file larger than ~2.1 GB failed on PostgreSQL withvalue out of int32 rangeduring INSERT. Change the ORM column toBigIntegerand add an alembic migration that runsALTER TABLE assets ALTER COLUMN size TYPE BIGINTon PostgreSQL.SQLite is unaffected because its
INTEGERaffinity already stores 64-bit values.Checklist
Add the ticket number which this PR closes to the comment section