scripts(deploy): add SystemDeploy wrapper script#352
Closed
rayyan224 wants to merge 2 commits into
Closed
Conversation
Introduces deploy.sh as the production entrypoint for SystemDeploy.s.sol, replacing the legacy Deploy.s.sol wrapper that was removed in #266. Supports both Ledger and raw private-key signing, optional contract verification, and a SALT_MIXER override for deploying new contract sets without colliding with existing CREATE2 addresses on the same l2ChainId. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
🟡 Heimdall Review Status
|
[ -n "${DEPLOY_VERIFY:-}" ] treated "0", "false", etc. as truthy,
silently enabling verification when the user intended to disable it.
Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/deploy/deploy.shas the production wrapper forSystemDeploy.s.sol, replacing the legacyDeploy.s.solwrapper removed in chore: cleanup #266DEPLOY_LEDGER=1+DEPLOY_HD_PATH) and raw private-key signing (DEPLOY_PRIVATE_KEY)DEPLOY_VERIFY=1with configurableVERIFIER_URLandETHERSCAN_API_KEYSALT_MIXERoverride for deploying a fresh contract set on an existingl2ChainIdwithout CREATE2 address collisionsTest plan
DEPLOY_ETH_RPC_URL=<hoodi-rpc> DEPLOY_CONFIG_PATH=deploy-config/zeronet.json DEPLOY_PRIVATE_KEY=<key> bash scripts/deploy/deploy.sh(remove--broadcastflag first for simulation)DEPLOY_LEDGER=1 DEPLOY_HD_PATH=m/44'/60'/0'/0/0and confirm--ledger --hd-pathsargs are passed throughDEPLOY_VERIFY=1appends--verify(and verifier flags) to the forge invocation