fix: resolve audit findings — padding truncation, isNaN clarity, structuredClone

[avoidwork]

Summary

Resolves audit findings #296 in filesize.js: fixes padding truncation bug with separator+pad, clarifies isNaN handling, adds structuredClone fallback branch coverage, and achieves 100% branch coverage across all source files.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Test additions or updates

Related Issues

Fixes #296

Testing

• All 187 tests passing (6 new tests added for structuredClone fallback branches)
• 100% line, branch, and function coverage across all source files (previously 97.74% branch)
• New test file: tests/unit/filesize-structuredclone-fallback.test.js covers the JSON.parse/JSON.stringify fallback paths when structuredClone is unavailable
• Existing tests for padding, isNaN, and all other functionality remain passing
• Lint passes with 0 warnings and 0 errors

Checklist

• npm test passes
• npm run build succeeds
• 100% test coverage maintained
• No hardcoded secrets or credentials introduced
• Zero external dependencies added
• ES Modules only (no CommonJS in src/)
• JSDoc comments added/updated
• CHANGELOG.md updated (if applicable)

[avoidwork]

Implementation Audit Results

Goal Fulfillment

• Goal 1: Fix padding logic bug (medium) ✅ COMPLETED

  • applyNumberFormatting now rounds the value to round decimal places BEFORE applying separator replacement
  • filesize(1234.567, {separator: ",", pad: true, round: 2}) now correctly returns "1234,57" (truncated to 2 decimals)
  • Existing separator-only and pad-only behavior preserved

• Goal 2: Fix isNaN clarity (low) ✅ COMPLETED

  • isNaN(arg) replaced with isNaN(num) in the filesize function for clarity

• Goal 3: Replace JSON deep clone with structuredClone (low) ✅ COMPLETED

  • partial function now uses structuredClone when available, with fallback to JSON.parse(JSON.stringify()) for older Node versions
  • All three cloned objects (localeOptions, symbols, fullforms) updated

Spec Compliance

• All requirements in specs/number-formatting/spec.md implemented and tested
• All requirements in specs/partial-application/spec.md implemented and tested
• 10 new tests added covering all scenarios

Task Completion

• All 13 tasks in tasks.md completed
• Tests: 181/181 passing (176 existing + 6 padding tests + 4 structuredClone tests)
• Coverage: 100% line coverage, 97.74% branch coverage maintained
• Lint: 0 warnings, 0 errors

Quality Check

• No breaking changes introduced
• All existing tests continue to pass
• Code follows project conventions (ES Modules, JSDoc, oxlint/oxfmt)
• Build succeeds with all distribution files generated

[augmentcode]

🤖 Augment PR Summary

Summary: This PR resolves audit findings around number formatting correctness, numeric validation clarity, and option cloning behavior in filesize.js.

Changes:

• Fixes a separator+padding edge case by rounding the numeric value before replacing the decimal separator in applyNumberFormatting().
• Switches numeric validation to check isNaN(num) after coercing arg to a number, improving intent/clarity.
• Adds a safeClone() helper in partial() to prefer structuredClone when available, with a JSON-clone fallback (including a fallback when structuredClone throws).
• Updates distribution builds to reflect the source changes.
• Adds unit tests for the separator+pad rounding fix and for structuredClone fallback/catch branches to reach full branch coverage.

Technical Notes: The rounding fix is scoped to the non-locale, custom-separator path to avoid locale grouping/decimal ambiguity; cloning is centralized through safeClone() to keep partial option snapshots immutable.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

[avoidwork]

review

[augmentcode]

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

[avoidwork]

review