[avocado-misc] Perf: Use the built perf binary [depends on https://github.com/avocado-framework/avocado/pull/6272] by Sumitupadhyay1 · Pull Request #3087 · avocado-framework-tests/avocado-misc-tests

Sumitupadhyay1 · 2026-02-16T07:48:03Z

Introduced support for specifying a custom perf binary path in misc tests.
Updated perf test scripts to call ensure_tool() from distro_packages
for dependency handling when a custom binary path is provided.
Added corresponding .data/ YAML files for test configuration.
Integrated perf tests into the avocado-misc-tests CI pipeline
to ensure consistency and reproducibility across environments.

Note:

This change depends on ensure_tool() introduced in Avocado:
[avocado-utils] : add validation for perf binary in ensure_tool() avocado-framework/avocado#6272

PraveenPenguin

LGTM

Sumitupadhyay1 · 2026-03-03T06:02:29Z

@nasastry, could you please review this pull request.

narasimhan-v · 2026-03-05T07:08:42Z

@PraveenPenguin can you please let us know if
we need to wait for @nasastry to review this one
or
can we merge this once the utils PR is merged ?

narasimhan-v · 2026-03-05T07:09:47Z

@PraveenPenguin can you also please help with moving forward on avocado-framework/avocado#6272 ?
Thanks in advance

Sumitupadhyay1 · 2026-03-10T05:47:13Z

@nasastry, could you please review this pull request and get it merged to the upstream.

Sumitupadhyay1 · 2026-03-13T04:17:50Z

@nasastry, could you please review this pull request and let me know if any changes required.

Sumitupadhyay1 · 2026-03-24T04:04:28Z

@nasastry, could you please review this pull request and let me know if any changes required.

PraveenPenguin · 2026-03-25T05:24:22Z

@PraveenPenguin can you also please help with moving forward on avocado-framework/avocado#6272 ? Thanks in advance

sure @narasimhan-v

Sumitupadhyay1 · 2026-03-31T04:56:26Z

@nasastry, could you please review this pull request.

Sumitupadhyay1 · 2026-04-01T06:04:05Z

Hi @PraveenPenguin, could you please help get this pull request merged? All checks have passed, there are no conflicts with the base branch, and the changes have already been approved. Merging this will allow us to proceed with avocado-framework/avocado#6272. Thanks for your support!

nasastry

LGTM

disgoel · 2026-04-15T06:06:04Z

install_distro_packages() returns False when packages are already installed. This causes ensure_tool() to raise RuntimeError. All tests CANCEL with "Failed to install packages for perf".

Raised PR to fix the issue avocado-framework/avocado#6298

[stdlog] 2026-04-15 11:29:22,142 avocado.utils.process process          L0662 INFO | Running 'rpm -q perf'
[stdlog] 2026-04-15 11:29:22,143 avocado.utils.process process          L0711 INFO | Command rpm -q perf running on a thread
[stdlog] 2026-04-15 11:29:22,193 avocado.utils.process process          L0475 DEBUG| [stdout] perf-6.12.0-211.7.1.el10_2.ppc64le
[stdlog] 2026-04-15 11:29:22,193 avocado.utils.process process          L0719 INFO | Command 'rpm -q perf' finished with 0 after 0.050102256s
[stdlog] 2026-04-15 11:29:22,193 avocado.test stacktrace       L0041 ERROR|
[stdlog] 2026-04-15 11:29:22,193 avocado.test stacktrace       L0043 ERROR| Reproduced traceback from: /usr/local/lib/python3.12/site-packages/avocado_framework-112.0-py3.12.egg/avocado/core/test.py:591
[stdlog] 2026-04-15 11:29:22,194 avocado.test stacktrace       L0050 ERROR| Traceback (most recent call last):
[stdlog] 2026-04-15 11:29:22,194 avocado.test stacktrace       L0050 ERROR|   File "/home/avocado-misc-tests/perf/perf_basic.py", line 72, in setUp
[stdlog] 2026-04-15 11:29:22,194 avocado.test stacktrace       L0050 ERROR|     perf_version = ensure_tool("perf", custom_path=perf_path, distro_pkg_map=distro_pkg_map)
[stdlog] 2026-04-15 11:29:22,194 avocado.test stacktrace       L0050 ERROR|                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[stdlog] 2026-04-15 11:29:22,195 avocado.test stacktrace       L0050 ERROR|   File "/usr/local/lib/python3.12/site-packages/avocado_framework-112.0-py3.12.egg/avocado/utils/software_manager/distro_packages.py", line 100, in ensure_tool
[stdlog] 2026-04-15 11:29:22,195 avocado.test stacktrace       L0050 ERROR|     raise RuntimeError(f"Failed to install packages for {tool_name}")
[stdlog] 2026-04-15 11:29:22,195 avocado.test stacktrace       L0050 ERROR| RuntimeError: Failed to install packages for perf

disgoel · 2026-04-15T08:18:29Z

Consider renaming YAML files to match their test names.

Sumitupadhyay1 · 2026-04-20T12:07:15Z

Consider renaming YAML files to match their test names.

@disgoel, Changes taken care. And test are working as expected. Could you please review and approve the same.

Sumitupadhyay1 · 2026-04-20T12:11:59Z

install_distro_packages() returns False when packages are already installed. This causes ensure_tool() to raise RuntimeError. All tests CANCEL with "Failed to install packages for perf".

Raised PR to fix the issue avocado-framework/avocado#6298

[stdlog] 2026-04-15 11:29:22,142 avocado.utils.process process          L0662 INFO | Running 'rpm -q perf'
[stdlog] 2026-04-15 11:29:22,143 avocado.utils.process process          L0711 INFO | Command rpm -q perf running on a thread
[stdlog] 2026-04-15 11:29:22,193 avocado.utils.process process          L0475 DEBUG| [stdout] perf-6.12.0-211.7.1.el10_2.ppc64le
[stdlog] 2026-04-15 11:29:22,193 avocado.utils.process process          L0719 INFO | Command 'rpm -q perf' finished with 0 after 0.050102256s
[stdlog] 2026-04-15 11:29:22,193 avocado.test stacktrace       L0041 ERROR|
[stdlog] 2026-04-15 11:29:22,193 avocado.test stacktrace       L0043 ERROR| Reproduced traceback from: /usr/local/lib/python3.12/site-packages/avocado_framework-112.0-py3.12.egg/avocado/core/test.py:591
[stdlog] 2026-04-15 11:29:22,194 avocado.test stacktrace       L0050 ERROR| Traceback (most recent call last):
[stdlog] 2026-04-15 11:29:22,194 avocado.test stacktrace       L0050 ERROR|   File "/home/avocado-misc-tests/perf/perf_basic.py", line 72, in setUp
[stdlog] 2026-04-15 11:29:22,194 avocado.test stacktrace       L0050 ERROR|     perf_version = ensure_tool("perf", custom_path=perf_path, distro_pkg_map=distro_pkg_map)
[stdlog] 2026-04-15 11:29:22,194 avocado.test stacktrace       L0050 ERROR|                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[stdlog] 2026-04-15 11:29:22,195 avocado.test stacktrace       L0050 ERROR|   File "/usr/local/lib/python3.12/site-packages/avocado_framework-112.0-py3.12.egg/avocado/utils/software_manager/distro_packages.py", line 100, in ensure_tool
[stdlog] 2026-04-15 11:29:22,195 avocado.test stacktrace       L0050 ERROR|     raise RuntimeError(f"Failed to install packages for {tool_name}")
[stdlog] 2026-04-15 11:29:22,195 avocado.test stacktrace       L0050 ERROR| RuntimeError: Failed to install packages for perf

@disgoel, Changes taken care. And test are working as expected. Could you please review and approve the same.

Sumitupadhyay1 · 2026-05-05T04:19:00Z

@disgoel, could you please review and approve this pull request. Merging this will allow us to proceed with avocado-framework/avocado#6272. Thanks for your support!

disgoel · 2026-05-07T06:44:21Z

@disgoel, could you please review and approve this pull request. Merging this will allow us to proceed with avocado-framework/avocado#6272. Thanks for your support!

@Sumitupadhyay1 can you look at review comments for perf_script_bug.py & perfmon.py. Otherwise looks good.

Sumitupadhyay1 · 2026-05-12T05:41:56Z

@disgoel, could you please review and approve this pull request. Merging this will allow us to proceed with avocado-framework/avocado#6272. Thanks for your support!

@Sumitupadhyay1 can you look at review comments for perf_script_bug.py & perfmon.py. Otherwise looks good.

@disgoel, Changes taken care. Could you please review and approve the same.

Sumitupadhyay1 · 2026-05-14T06:43:46Z

@disgoel, all the requested changes taken care. Could you please review and approve this pull request.

PraveenPenguin · 2026-05-18T05:02:48Z

@Sumitupadhyay1 can you please squash in logical commits .. @disgoel please review

- Introduced support for specifying a custom perf binary path. - Updated perf test scripts to use ensure_tool() from distro_packages for handling dependent packages when a perf binary path is provided. - Added corresponding .data/ YAML files for test configuration. Signed-off-by: Sumit Kumar <sumitkum@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>

- Rename .data YAML files to match test module names; set perf_bin to /tmp/perf. - Restore perf_duplicate.yaml mux (run_type) for perf_duplicate_probe. - perfmon: mux perf_bin without ensure_tool; install only build deps. - perf_script_bug: align with ensure_tool and perf_script_bug.yaml naming. Signed-off-by: Sumit Kumar <sumitkum@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>

@disgoel

Address review feedback from @disgoel on PR avocado-framework-tests#3087: - Remove the perf_bin mux block in setUp(); tests/validate uses system perf via PATH, so self.perf_bin was never consumed. - Drop associated state (_mux_perf_bin, _saved_path) and PATH restore logic that only existed to support the dead block. - Remove the unnecessary "libpfm4 build deps only" comment. - Trim now-dead perf_bin entries from perfmon.py.data yaml(s). Signed-off-by: Sumit Kumar <sumitkum@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>

disgoel

@Sumitupadhyay1 Thanks for addressing the review comments. LGTM

Sumitupadhyay1 · 2026-05-25T08:20:07Z

@nasastry, Could you please approve and merge this pull request.

narasimhan-v · 2026-05-26T09:03:04Z

@PraveenPenguin Since the patch is approved, merging it.

Sumitupadhyay1 force-pushed the Perf_test_integration branch 4 times, most recently from 744bff9 to 105e34b Compare February 26, 2026 12:56

narasimhan-v self-assigned this Feb 26, 2026

narasimhan-v requested review from PraveenPenguin and nasastry February 26, 2026 13:00

PraveenPenguin approved these changes Feb 28, 2026

View reviewed changes

narasimhan-v changed the title ~~[avocado-misc] Perf: Use the built perf binary~~ [avocado-misc] Perf: Use the built perf binary [depends on https://github.com/avocado-framework/avocado/pull/6272] Mar 5, 2026

narasimhan-v assigned PraveenPenguin and unassigned narasimhan-v Apr 3, 2026

nasastry approved these changes Apr 15, 2026

View reviewed changes

disgoel suggested changes Apr 15, 2026

View reviewed changes

Comment thread perf/perf_script_bug.py Outdated

Comment thread perf/perfmon.py Outdated

disgoel reviewed Apr 20, 2026

View reviewed changes

Comment thread perf/perf_duplicate_probe.py.data/perf_duplicate.yaml

narasimhan-v requested a review from disgoel April 27, 2026 05:04

disgoel reviewed May 12, 2026

View reviewed changes

Comment thread perf/perfmon.py Outdated

disgoel reviewed May 12, 2026

View reviewed changes

Comment thread perf/perfmon.py Outdated

Sumitupadhyay1 force-pushed the Perf_test_integration branch from 00f8ec0 to 9273c70 Compare May 12, 2026 10:33

narasimhan-v requested a review from disgoel May 13, 2026 05:13

Sumitupadhyay1 force-pushed the Perf_test_integration branch from f074608 to 34998b1 Compare May 18, 2026 05:24

Sumitupadhyay1 and others added 2 commits May 18, 2026 10:55

Sumitupadhyay1 force-pushed the Perf_test_integration branch from 34998b1 to 67aad1f Compare May 18, 2026 05:26

disgoel reviewed May 22, 2026

View reviewed changes

Comment thread perf/perfmon.py Outdated

disgoel reviewed May 22, 2026

View reviewed changes

Comment thread perf/perfmon.py Outdated

Sumitupadhyay1 requested a review from disgoel May 25, 2026 07:31

disgoel approved these changes May 25, 2026

View reviewed changes

narasimhan-v merged commit 3486174 into avocado-framework-tests:master May 26, 2026
5 checks passed

Conversation

Sumitupadhyay1 commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PraveenPenguin left a comment

Choose a reason for hiding this comment

Uh oh!

Sumitupadhyay1 commented Mar 3, 2026

Uh oh!

narasimhan-v commented Mar 5, 2026

Uh oh!

narasimhan-v commented Mar 5, 2026

Uh oh!

Sumitupadhyay1 commented Mar 10, 2026

Uh oh!

Sumitupadhyay1 commented Mar 13, 2026

Uh oh!

Sumitupadhyay1 commented Mar 24, 2026

Uh oh!

PraveenPenguin commented Mar 25, 2026

Uh oh!

Sumitupadhyay1 commented Mar 31, 2026

Uh oh!

Sumitupadhyay1 commented Apr 1, 2026

Uh oh!

nasastry left a comment

Choose a reason for hiding this comment

Uh oh!

disgoel commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

disgoel commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

Sumitupadhyay1 commented Apr 20, 2026

Uh oh!

Sumitupadhyay1 commented Apr 20, 2026

Uh oh!

Uh oh!

Sumitupadhyay1 commented May 5, 2026

Uh oh!

disgoel commented May 7, 2026

Uh oh!

Sumitupadhyay1 commented May 12, 2026

Uh oh!

Uh oh!

Uh oh!

Sumitupadhyay1 commented May 14, 2026

Uh oh!

PraveenPenguin commented May 18, 2026

Uh oh!

Uh oh!

Uh oh!

disgoel left a comment

Choose a reason for hiding this comment

Uh oh!

Sumitupadhyay1 commented May 25, 2026

Uh oh!

narasimhan-v commented May 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Sumitupadhyay1 commented Feb 16, 2026 •

edited

Loading

disgoel commented Apr 15, 2026 •

edited

Loading