Remove redundant Visual Guide link from resources page#201
Conversation
The bit.ly link duplicated content already covered by the Solr Reference Guide link above it.
|
|
||
| * [Solr Reference Guide](/guide) | ||
|
|
||
| * [Visual Guide to Streaming Expressions and Math Expressions](http://bit.ly/32srTpA) |
There was a problem hiding this comment.
-0. So, this is a werid thing that has been bugging me for YEARS! The link for the visual guide takes you to https://github.com/apache/lucene-solr/blob/visual-guide/solr/solr-ref-guide/src/math-expressions.adoc#streaming-expressions-and-math-expressions. Notice the old lucene-solr URL?
I believe this is a weird fork of content that never really got brought into the main solr project....
There was a problem hiding this comment.
humm... okay, I was wrong, this did get brought in....
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
Okay, I need to remove my -1. Having said that, while it's technically jsut part of the ref guide, it is a whole big section of content, that really is written in it's own style and flavour, and I'd love to instead just see the link converted to https://solr.apache.org/guide/solr/latest/query-guide/math-expressions.html#a-visual-guide instead.....
|
I don't like this second link here at all -- it's redundant and IMO out-of-place. No matter how amazing or different that content is, I'm not moved. If you think that amazing content needs to be surfaced more, then please do so at locations scoped to that feature, which is where such links would be useful. Like within the ref guide, maybe there are more opportunities for helpful links. Perhaps there are opportunities for more javadoc links to this guide. I'm speaking theoretically; I have no idea how well linked they may or may not be at present. |
|
note: you didn't remove your -1 despite you saying you did. Notice the PR review state. |
hum, I think I did. I chagned it to -0 and my review status to comment versus request changes. |
2 participants
Summary
Test plan