refactor: apply misc Java 11-17 improvements#3193
Merged
Merged
Conversation
Motivation: Modernize Java code to use Java 11-17 APIs for cleaner, more idiomatic code. Modification: - String.isBlank() replacing trim().isEmpty() - Collection.toArray(IntFunction) replacing toArray(new X[0]) - Map.forEach replacing entrySet iteration loops - Text blocks replacing multi-line string concatenation - Records replacing simple data holder classes Result: Cleaner, more modern Java code using Java 11-17 features.
This was referenced Jun 26, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
String.isBlank()replacingtrim().isEmpty()Collection.toArray(IntFunction)replacingtoArray(new X[0])Map.forEachreplacing entrySet iteration loops"""..."""replacing multi-line string concatenationChanges
String.isBlank() (Java 11+)
ShardingEventSourcedEntityWithEnforcedRepliesCompileOnlyTest.javaCollection.toArray(IntFunction) (Java 11+)
GraphDslTest.java—toArray(new String[] {})→toArray(String[]::new)BidiFlowDocTest.java—toArray(new Message[0])→toArray(Message[]::new)Map.forEach (Java 8+)
ReplicatedShoppingCartExample.java— entrySet loop →cart.forEach((k, v) -> ...)DeviceGroupQuery.java— entrySet loop →deviceIdToActor.forEach((k, v) -> ...)Text blocks (Java 15+)
SubstreamDocTest.java— 3-line string concat → text blockTestConfigExample.java— config string concatenations → text blocksRecords (Java 16+)
ImmutableMessage.java→record ImmutableMessage(int sequenceNumber, List<String> values)Messages.javainner class → recordMessage.Person→record Person(String first, String last)Bid.java→record Bid(UUID bidder, Instant bidTime, int bidPrice, int maximumBid)AuctionEntity.javaandAuctionState.java(getter names adjusted)Notes
javafmtAllverified — no formatting changes needed