Skip to content

NIFI-16046: Initial implementation for Processor / Connector Backlog#11435

Open
markap14 wants to merge 1 commit into
apache:mainfrom
markap14:nifi-connector-backlog
Open

NIFI-16046: Initial implementation for Processor / Connector Backlog#11435
markap14 wants to merge 1 commit into
apache:mainfrom
markap14:nifi-connector-backlog

Conversation

@markap14

Copy link
Copy Markdown
Contributor

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@pvillard31 pvillard31 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to spend some time actually testing it but it LGTM from a code implementation PoV, a couple of comments that could be follow-up:

  • The cluster merger (BacklogRequestEndpointMerger.mergeEntities) re-implements the same precision/sum/earliest-timestamp rules as Backlog.plus(). A shared helper that both the API and the DTO layer delegate to would avoid any potential drift.
  • The API says calls are ~1/min and implementations may cache. For an expensive source query (a Kafka Admin round-trip, a Postgres WAL diff), it would help to have a small framework-provided TTL cache or at least a documented pattern, so every new implementer doesn't reinvent it and accidentally hammer the source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants