NIFI-16046: Initial implementation for Processor / Connector Backlog#11435
Open
markap14 wants to merge 1 commit into
Open
NIFI-16046: Initial implementation for Processor / Connector Backlog#11435markap14 wants to merge 1 commit into
markap14 wants to merge 1 commit into
Conversation
pvillard31
reviewed
Jul 17, 2026
pvillard31
left a comment
Contributor
There was a problem hiding this comment.
I'll try to spend some time actually testing it but it LGTM from a code implementation PoV, a couple of comments that could be follow-up:
- The cluster merger (
BacklogRequestEndpointMerger.mergeEntities) re-implements the same precision/sum/earliest-timestamp rules asBacklog.plus(). A shared helper that both the API and the DTO layer delegate to would avoid any potential drift. - The API says calls are ~1/min and implementations may cache. For an expensive source query (a Kafka Admin round-trip, a Postgres WAL diff), it would help to have a small framework-provided TTL cache or at least a documented pattern, so every new implementer doesn't reinvent it and accidentally hammer the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation