Skip to content

NIFI-16021 Improved JoltTransformJSON error message when specified JOLT spec is invalid and ensured leading single and multi-line Java comments are supported when the Jolt spec is specified as text. #11426

Open
dan-s1 wants to merge 3 commits into
apache:mainfrom
dan-s1:NIFI-16021

Conversation

@dan-s1

@dan-s1 dan-s1 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

NIFI-16021

Also added tests to ensure ValidateJson causes Json parsing exception when any Java comments is specified before or inside a schema.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

…LT spec is invalid and ensured leading single and multi-line Java comments are supported when the Jolt spec is specified as text. Also added tests to ensure ValidateJson causes Json parsing exception when any Java comments is specified before or inside a schema.
@dan-s1 dan-s1 changed the title NIFI-16021 Improved JoltTransformJSON error message when specified JOLT spec is invalid and ensured leading single and multi-line Java comments are supported when the Jolt spec is specified as text. Also added tests to ensure ValidateJson causes Json parsing exception when any Java comments is specified before or inside a schema. NIFI-16021 Improved JoltTransformJSON error message when specified JOLT spec is invalid and ensured leading single and multi-line Java comments are supported when the Jolt spec is specified as text. Jul 13, 2026
@dan-s1 dan-s1 added the bug label Jul 13, 2026

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1. Although changing the message itself is one approach, it seems better to handle the formatting in the custom validation method. This would align with the general practice of avoiding including exception cause messages. It would also avoid changing runtime behavior for the sake of the validation method.

@dan-s1

dan-s1 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@exceptionfactory Please let me know if the latest change is what you had in mind. Thanks!

@dan-s1
dan-s1 requested a review from exceptionfactory July 13, 2026 21:44

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1, the revised approach looks closer to what I had in mind. I recommendation a small adjustment.

@dan-s1
dan-s1 requested a review from exceptionfactory July 13, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants