NIFI-16021 Improved JoltTransformJSON error message when specified JOLT spec is invalid and ensured leading single and multi-line Java comments are supported when the Jolt spec is specified as text. #11426
Open
dan-s1 wants to merge 3 commits into
Conversation
…LT spec is invalid and ensured leading single and multi-line Java comments are supported when the Jolt spec is specified as text. Also added tests to ensure ValidateJson causes Json parsing exception when any Java comments is specified before or inside a schema.
exceptionfactory
requested changes
Jul 13, 2026
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks @dan-s1. Although changing the message itself is one approach, it seems better to handle the formatting in the custom validation method. This would align with the general practice of avoiding including exception cause messages. It would also avoid changing runtime behavior for the sake of the validation method.
…ied the cause message in customValidate.
Contributor
Author
|
@exceptionfactory Please let me know if the latest change is what you had in mind. Thanks! |
exceptionfactory
requested changes
Jul 13, 2026
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks @dan-s1, the revised approach looks closer to what I had in mind. I recommendation a small adjustment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16021
Also added tests to ensure ValidateJson causes Json parsing exception when any Java comments is specified before or inside a schema.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation