IGNITE-28821 Protected Classes CI check: report as warning instead of failing the PR build#13279
Open
anton-vinogradov wants to merge 1 commit into
Open
IGNITE-28821 Protected Classes CI check: report as warning instead of failing the PR build#13279anton-vinogradov wants to merge 1 commit into
anton-vinogradov wants to merge 1 commit into
Conversation
… failing the PR build Replace the hard `exit 1` with a separate non-blocking check "Rolling upgrade compatibility" (action_required conclusion), keeping the existing PR comment and `compatibility` label. The main "Rolling Upgrade check" job now always succeeds. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
Protected Classesworkflow no longer fails the PR build when a change touches@Order-annotated (protected) classes. Instead it publishes a separate, non-blocking checkRolling upgrade compatibilitywith theaction_requiredconclusion (yellow marker), keeping the existing PR comment andcompatibilitylabel.Why
A hard failure (
exit 1) red-flagged PRs even for intentional, compatible changes, creating friction (the check was disabled manually on 2026-05-27 for this reason). A warning surfaces the rolling-upgrade risk for reviewer attention without failing the build.Notes
Rolling Upgrade checkjob now always succeeds.checks: writepermission added for the Checks API call.Jira: https://issues.apache.org/jira/browse/IGNITE-28821
🤖 Generated with Claude Code