Skip to content

fix(java): Stabilize async consumer group test #3697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryerraguntla wants to merge 3 commits into
base: master
Choose a base branch
from
+71 −24
Open

fix(java): Stabilize async consumer group test #3697

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd69c12
Stabilize async consumer group test
ryerraguntla Jul 18, 2026
e80aa58
Reformat long method signatures in consumer group tests
ryerraguntla Jul 18, 2026
9bda9da
Merge branch 'master' into fix(java-sdk)/3641-flaky-async-consumer-gr…
ryerraguntla Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 71 additions & 24 deletions ...ign/java/java-sdk/src/test/java/org/apache/iggy/client/async/AsyncConsumerGroupsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.slf4j.LoggerFactory;

import java.math.BigInteger;
import java.time.Duration;
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
Expand Down Expand Up @@ -62,6 +63,8 @@ public class AsyncConsumerGroupsTest extends BaseIntegrationTest {
private static final String TEST_STREAM = "async-cg-test-stream-" + UUID.randomUUID();
private static final String TEST_TOPIC = "async-cg-test-topic";
private static final int TIMEOUT_SECONDS = 5;
private static final Duration TRANSIENT_RETRY_TIMEOUT = Duration.ofSeconds(5);
private static final Duration TRANSIENT_RETRY_BACKOFF = Duration.ofMillis(75);

private static final StreamId STREAM_ID = StreamId.of(TEST_STREAM);
private static final TopicId TOPIC_ID = TopicId.of(TEST_TOPIC);
Expand Down Expand Up @@ -324,35 +327,79 @@ void shouldHandleConcurrentJoinAndLeaveOperations() throws Exception {
.get(TIMEOUT_SECONDS, TimeUnit.SECONDS);

// when — join concurrently
CompletableFuture.allOf(
client.consumerGroups().joinConsumerGroup(STREAM_ID, TOPIC_ID, groupId),
secondClient.consumerGroups().joinConsumerGroup(STREAM_ID, TOPIC_ID, groupId),
thirdClient.consumerGroups().joinConsumerGroup(STREAM_ID, TOPIC_ID, groupId))
.get(TIMEOUT_SECONDS * 2, TimeUnit.SECONDS);

// then
ConsumerGroupDetails afterJoin = client.consumerGroups()
.getConsumerGroup(STREAM_ID, TOPIC_ID, groupId)
.get(TIMEOUT_SECONDS, TimeUnit.SECONDS)
.get();
assertThat(afterJoin.membersCount()).isEqualTo(3);
retryOnTransientNotFound(
() -> CompletableFuture.allOf(
client.consumerGroups().joinConsumerGroup(STREAM_ID, TOPIC_ID, groupId),
secondClient.consumerGroups().joinConsumerGroup(STREAM_ID, TOPIC_ID, groupId),
thirdClient.consumerGroups().joinConsumerGroup(STREAM_ID, TOPIC_ID, groupId))
.get(TIMEOUT_SECONDS * 2, TimeUnit.SECONDS),
TRANSIENT_RETRY_TIMEOUT,
TRANSIENT_RETRY_BACKOFF);
awaitMembersCount(groupId, 3);

// when — leave concurrently
CompletableFuture.allOf(
client.consumerGroups().leaveConsumerGroup(STREAM_ID, TOPIC_ID, groupId),
secondClient.consumerGroups().leaveConsumerGroup(STREAM_ID, TOPIC_ID, groupId),
thirdClient.consumerGroups().leaveConsumerGroup(STREAM_ID, TOPIC_ID, groupId))
.get(TIMEOUT_SECONDS * 2, TimeUnit.SECONDS);

// then
ConsumerGroupDetails afterLeave = client.consumerGroups()
.getConsumerGroup(STREAM_ID, TOPIC_ID, groupId)
.get(TIMEOUT_SECONDS, TimeUnit.SECONDS)
.get();
assertThat(afterLeave.membersCount()).isEqualTo(0);
retryOnTransientNotFound(
() -> CompletableFuture.allOf(
client.consumerGroups().leaveConsumerGroup(STREAM_ID, TOPIC_ID, groupId),
secondClient.consumerGroups().leaveConsumerGroup(STREAM_ID, TOPIC_ID, groupId),
thirdClient.consumerGroups().leaveConsumerGroup(STREAM_ID, TOPIC_ID, groupId))
.get(TIMEOUT_SECONDS * 2, TimeUnit.SECONDS),
TRANSIENT_RETRY_TIMEOUT,
TRANSIENT_RETRY_BACKOFF);
awaitMembersCount(groupId, 0);
Comment on lines -341 to +349

@slbotbm slbotbm Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, if one leave succeeds while another returns IggyResourceNotFoundException, retry resubmits all three leaves. Already-successful client now returns “member not found,” so every later attempt fails. Helper eventually times out even if member count reaches zero. This defeats exact flaky case being fixed.

fix: Treat “already left” as success, retry clients individually, or tolerate leave exceptions and use awaitMembersCount(groupId, 0) as final condition.

} finally {
secondClient.close().get(TIMEOUT_SECONDS, TimeUnit.SECONDS);
thirdClient.close().get(TIMEOUT_SECONDS, TimeUnit.SECONDS);
}
}

@FunctionalInterface
private interface ThrowingRunnable {
void run() throws Exception;
}

private static void retryOnTransientNotFound(ThrowingRunnable action, Duration timeout, Duration backoff)
throws Exception {
long deadlineNanos = System.nanoTime() + timeout.toNanos();
Throwable last = null;

while (System.nanoTime() < deadlineNanos) {
try {
action.run();
return;
} catch (ExecutionException exception) {
if (exception.getCause() instanceof IggyResourceNotFoundException) {
last = exception.getCause();
Thread.sleep(backoff.toMillis());
continue;
}
throw exception;
} catch (IggyResourceNotFoundException exception) {
last = exception;
Thread.sleep(backoff.toMillis());
}
}

throw new AssertionError("Timed out waiting for stable consumer-group state after transient not-found", last);
}

private void awaitMembersCount(ConsumerId groupId, int expectedCount) throws Exception {
long deadlineNanos = System.nanoTime() + TRANSIENT_RETRY_TIMEOUT.toNanos();

while (System.nanoTime() < deadlineNanos) {
Optional<ConsumerGroupDetails> group = client.consumerGroups()
.getConsumerGroup(STREAM_ID, TOPIC_ID, groupId)
.get(TIMEOUT_SECONDS, TimeUnit.SECONDS);
if (group.isPresent() && group.get().membersCount() == expectedCount) {
return;
}
Thread.sleep(TRANSIENT_RETRY_BACKOFF.toMillis());
}

ConsumerGroupDetails group = client.consumerGroups()
.getConsumerGroup(STREAM_ID, TOPIC_ID, groupId)
.get(TIMEOUT_SECONDS, TimeUnit.SECONDS)
.orElseThrow();
assertThat(group.membersCount()).isEqualTo(expectedCount);
}
}
Loading