[server] Reject KV leader promotion under disk write lock#3539
Open
swuferhong wants to merge 1 commit into
Open
[server] Reject KV leader promotion under disk write lock#3539swuferhong wants to merge 1 commit into
swuferhong wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3538
When a
TabletServeris under data disk write protection, making aprimary-key table replica leader may download KV snapshots and consume
more local disk space. This can fill the disk during leader migration
and amplify failures when the cluster is already under high disk usage.
Reject new KV leader promotion with
DISK_WRITE_LOCKEDwhen the localtablet server is write-locked. Log table leader promotion and idempotent
leader notifications are not affected.
Brief change log
Tests
API and Format
Documentation