feat: support theta and tuple a-not-b#155
Open
ariesdevil wants to merge 1 commit into
Open
Conversation
ariesdevil
force-pushed
the
tuple-a-not-b
branch
3 times, most recently
from
July 23, 2026 03:26
e4cbc3f to
2902e5e
Compare
ariesdevil
force-pushed
the
tuple-a-not-b
branch
9 times, most recently
from
July 24, 2026 15:00
32d85e8 to
1d29301
Compare
Member
|
#154 is merged now. I wonder if we'd have a |
ariesdevil
force-pushed
the
tuple-a-not-b
branch
2 times, most recently
from
July 25, 2026 03:09
8b9e68f to
373584c
Compare
ZENOTME
reviewed
Jul 25, 2026
ariesdevil
force-pushed
the
tuple-a-not-b
branch
from
July 25, 2026 04:02
373584c to
ff2bb8d
Compare
ariesdevil
marked this pull request as draft
July 25, 2026 04:18
ariesdevil
force-pushed
the
tuple-a-not-b
branch
from
July 25, 2026 04:21
ff2bb8d to
b557095
Compare
ariesdevil
changed the title
tisonkun
reviewed
Jul 25, 2026
Member
There was a problem hiding this comment.
I have some ideas on factoring out this test utility support module. Will do once this PR gets merged.
Member
There was a problem hiding this comment.
... to avoid too much #[cfg(feature = "...")] and #[allow(dead_code)].
tisonkun
reviewed
Jul 25, 2026
Member
tisonkun
reviewed
Jul 25, 2026
tisonkun
left a comment
tisonkun
left a comment
Member
There was a problem hiding this comment.
Generally LGTM.
Anything keeps this PR a draft before it's ready for review and merge?
ariesdevil
marked this pull request as ready for review
July 25, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #152 #153 #154