GH-49889: [C++][Compute] Handle logical nulls in validity kernels#50269
Open
hadrian-reppas wants to merge 3 commits into
Open
GH-49889: [C++][Compute] Handle logical nulls in validity kernels#50269hadrian-reppas wants to merge 3 commits into
hadrian-reppas wants to merge 3 commits into
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I was looking into #49889 and updated the handling of logical nulls in the
is_valid,is_null, andtrue_unless_nullkernels. It turns out there is some prior work here that I didn't see before I starting implementing my fix (#35058, #35036, #37642). For some reason, that work has stalled.What changes are included in this PR?
This PR updates the
IsValidExec,IsNullExec, andTrueUnlessNullExeckernels so that they call out to a new functionSetLogicalNullBits. TheSetLogicalNullBitsfunction matches the logic inArraySpan::ComputeLogicalNullCount(). The logic is similar enough that they may be some opportunities for code deduplication indict_util.ccandree_util.cc.Are these changes tested?
Yes
Are there any user-facing changes?
No
true_unless_nullkernel output incorrect when run-end encoded array contains null #49889