GH-50231: Handle unset Substrait extension mapping type#50263
Open
Reranko05 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A malformed Substrait
SimpleExtensionDeclarationwith an unsetmapping_typecurrently reachesUnreachable(), causing the process to abort during deserialization. Since this can be triggered by malformed input, the deserializer should instead return anInvalidstatus.What changes are included in this PR?
Unreachable()call inGetExtensionSetFromMessagewith aStatus::Invalidreturn for unset or unknownmapping_typevalues.SimpleExtensionDeclarationreturns anInvalidstatus instead of aborting.Are these changes tested?
Yes. A regression test covering the malformed
SimpleExtensionDeclarationcase has been added toserde_test.cc.Are there any user-facing changes?
No.
This PR contains a "Critical Fix".
This change prevents process termination when deserializing malformed Substrait plans or expressions by returning a proper error instead of calling
std::abort().Unreachable()/std::abort()on aSimpleExtensionDeclarationwith an unsetmapping_typeoneof #50231