Skip to content

GH-50236: Remove obsolete OpenSUSE 15.5 workarounds#50258

Open
Shally-Katariya wants to merge 1 commit into
apache:mainfrom
Shally-Katariya:drop-opensuse-workarounds
Open

GH-50236: Remove obsolete OpenSUSE 15.5 workarounds#50258
Shally-Katariya wants to merge 1 commit into
apache:mainfrom
Shally-Katariya:drop-opensuse-workarounds

Conversation

@Shally-Katariya

@Shally-Katariya Shally-Katariya commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

Apache Arrow no longer supports the OpenSUSE 15.5 build configuration that required explicit shared_ptr and unique_ptr constructions.

This PR removes obsolete OpenSUSE 15.5-specific workarounds and simplifies the affected return statements by relying on standard implicit conversions.

What changes are included in this PR?

  • Removed OpenSUSE 15.5-specific workaround comments.
  • Replaced explicit std::shared_ptr<T>(std::move(...)) constructions with direct returns.
  • Replaced explicit std::unique_ptr<T>(std::move(...)) constructions with direct returns.
  • Simplified code in the affected Arrow C++ source files without changing functionality.

Are these changes tested?

Yes.

The changes were verified by building the affected components and running the relevant compute test suite:

ninja arrow-compute-tests
ctest -R "arrow-compute" --output-on-failure

All tests passed successfully.

Are there any user-facing changes?

No. This change is an internal code cleanup and does not affect public APIs, behavior, or user-facing functionality.

@pitrou

pitrou commented Jun 25, 2026

Copy link
Copy Markdown
Member

@Shally-Katariya Can you fix the C++ formatting? You should be able to do it using pre-commit run -a cpp

@Shally-Katariya Shally-Katariya force-pushed the drop-opensuse-workarounds branch from 5494d3e to 571fe82 Compare June 25, 2026 12:55
@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants