GH-50197: [C++][Python] Add "hypot" compute kernel#50198
Open
shrivasshankar wants to merge 1 commit into
Open
Conversation
shrivasshankar
requested review from
AlenkaF,
pitrou,
raulcd and
rok
as code owners
|
|
github-actions
Bot
added
Component: C++
Component: Python
Component: Documentation
labels
Add a binary floating-point compute function "hypot" that computes the hypotenuse sqrt(x^2 + y^2) without undue overflow or underflow at intermediate stages, mirroring numpy.hypot and std::hypot. The kernel reuses the existing MakeArithmeticFunctionFloatingPoint factory (as atan2 does), registering float32 and float64 kernels and promoting integer/decimal inputs to float64 via DispatchBest. Also adds the Hypot() convenience function and declaration, a FunctionDoc, C++ tests (including an overflow-safety test that exercises inputs whose squares overflow float32), a compute.rst entry, and pyarrow expression coverage.
shrivasshankar
force-pushed
the
feature/add-hypot-kernel
branch
from
1978af2 to
9568a77
Compare
Author
|
i rebased on main @pitrou could you check this out |
Member
|
This looks good. Consider adding arrow/docs/source/python/api/compute.rst Lines 161 to 181 in 12b3eda |
rok
reviewed
Jun 24, 2026
Comment on lines
+374
to
+375
| static_assert(std::is_same<T, Arg0>::value, ""); | ||
| static_assert(std::is_same<Arg0, Arg1>::value, ""); |
Member
There was a problem hiding this comment.
All all these assertions necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Arrow has
atan2andlogbbut nohypot. Computing a Euclidean norm currently needssqrt(add(multiply(x, x), multiply(y, y))), which can overflow at themultiplystep even when the result is representable.What changes are included in this PR?
Add a
hypotkernel backed bystd::hypot(float32/float64, with integer/decimal inputs promoted to float64), theHypot()C++ function, aFunctionDocandcompute.rstentry, and a Python expression test.pc.hypotis auto-exposed from the registry.Are these changes tested?
Yes, C++ tests for the basic cases, null/NaN/Inf handling, and an overflow case confirming it doesn't fall back to a naive
sqrt(x*x + y*y).Are there any user-facing changes?
Yes, a new
hypotfunction in C++ and Python. Additive only.