Update default version in parquet.rst#37227
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
|
Not sure when these docs get published, but if it's not until 13.0, maybe it would be better to update this doc to |
|
Could you read the automated comment about our contribution guide? Could you also use our PR template instead of removing it entirely? You're right. We should use "2.6" instead of "2.4" now. |
|
Sorry I figured that this change was small enough to be considered a minor PR. Should I create an issue for this? Or you just mean I should rename the PR title? |
|
(In general, it's better that contributors read contribution guide provided by a project.) If we can use "2.4", this is a MINOR change. But we can't use "2.4". We need to use "2.6". If we use "2.6", we need more changes. For example, "the nanoseconds will be cast to microseconds ('us')" isn't done with "2.6". We need to update the description too. |
|
Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer. |
|
Not stale because the docs on main here still state the default Parquet version as 1.0, but this PR still needs to be updated |
|
Thanks @kylebarron, I've removed the label now. |
|
hi, @kylebarron! I stumbled upon this issue-less PR so I opened the required issue #50228 and suggested newer updates in PR #50228 - Could you check those are good to go? Or do you prefer to continue on this PR instead? |
… in parquet.rst (#50228) ### Rationale for this change See #50227 - Python Parquet section [Storing timestamps](https://arrow.apache.org/docs/dev/python/parquet.html#storing-timestamps) mentions version 1.0 is the default write version but the actual [default has been 2.6 ](https://github.com/apache/arrow/blame/98ee71ec2be85d3ac535be367c6edacc0bc09c7c/python/pyarrow/parquet/core.py#L1996) for some time. (Replace old pr #37227) ### What changes are included in this PR? Update the default Parquet version text 1.0 -> 2.6 in `docs/source/python/parquet.rst`. ### Are these changes tested? Docs build fine locally. ### Are there any user-facing changes? No. * GitHub Issue: #50227 Authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
|
Closing in favour of #50227. |
According to https://arrow.apache.org/docs/python/generated/pyarrow.parquet.write_table.html, the default Parquet version written is now
2.4, not1.0