Minor updates to text message sync#2209
Merged
Merged
Conversation
This is a small follow on to apache#2188 to simply some of the sync by moving to the method level and also adding sync in a spot or 2 that got missed. This commit also updates the race condition test to add all the other message types to show that they do not suffer from the same race condition with null bodies either.
jbonofre
approved these changes
Jul 10, 2026
jbonofre
left a comment
jbonofre
left a comment
Member
There was a problem hiding this comment.
LGTM.
The test could be simplified imho, but that's allright.
github-project-automation
Bot
moved this from Backlog
to Done
in Apache ActiveMQ v6.3.0
cshannon
added a commit
to cshannon/activemq
that referenced
this pull request
Jul 10, 2026
This is a small follow on to apache#2188 to simply some of the sync by moving to the method level and also adding sync in a spot or 2 that got missed. This commit also updates the race condition test to add all the other message types to show that they do not suffer from the same race condition with null bodies either. (cherry picked from commit 04b5193)
cshannon
added a commit
that referenced
this pull request
Jul 10, 2026
This is a small follow on to #2188 to simply some of the sync by moving to the method level and also adding sync in a spot or 2 that got missed. This commit also updates the race condition test to add all the other message types to show that they do not suffer from the same race condition with null bodies either. (cherry picked from commit 04b5193)
cshannon
added a commit
that referenced
this pull request
Jul 10, 2026
This is a small follow on to #2188 to simply some of the sync by moving to the method level and also adding sync in a spot or 2 that got missed. This commit also updates the race condition test to add all the other message types to show that they do not suffer from the same race condition with null bodies either. (cherry picked from commit 04b5193)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small follow on to #2188 to simply some of the sync by moving to the method level and also adding sync in a spot or 2 that got missed.
This commit also updates the race condition test to add all the other message types to show that they do not suffer from the same race condition with null bodies either.
As noted in #2188, only text message needs sync because the other message types do not null out the marshalled content when unmarshalling. Properties are also ok because unmarshalling properties do not clear the marshalled properties either (unless told to at specific spots in the broker when reduceMemoryFootPrint is true)