[6.2.x] feat(#1828): Expose NetworkConnector URI and local URI in JMX MBean (activemq-6.2.x)#2208
Conversation
…Bean Add getUri() and getLocalUri() attributes to NetworkConnectorViewMBean so that the network connector URI is visible via JMX. Add abstract getUri() to NetworkConnector base class and implement it in MulticastNetworkConnector. Backport of apache#1829 to activemq-6.2.x.
|
nit: Once v6.3.0 we should tighten up our back-port policies to not back-port new fields. |
|
@mattrpav it's not breaking change as it's new fields. I'm fine to close it, but adding fields or features that don't impact (breaking change) is reasonable to me. That said, as 6.3.0 is coming 😄 let me close this backport one. |
|
@jbonofre no need to close this, esp since 6.3.x has taken a while to get out. This is minor, but I think we need to clarify for going forward. Adding a metric to a network connector isn't a big deal, but a config flag to queue or kahadb could be. Changing bin/setenv OPTS variables, causes admins to have to re-work packaging bundles b/w point releases, etc. So I think 'adding a field' can be too reductive and over arching. Keep this one for 6.2.x, I think we need clarify and possibly add a SEMVER.md for clarity all around |
Backport of #1829 to the
activemq-6.2.xbranch.Summary
getUri()andgetLocalUri()toNetworkConnectorViewMBeanso the network connector URI is visible via JMX.abstract getUri()to theNetworkConnectorbase class.getUri()inMulticastNetworkConnector(delegates togetRemoteURI()).DiscoveryNetworkConnectorandLdapNetworkConnectoralready hadgetUri()implementations and satisfy the new abstract contract without changes.JmxCreateNCTestto assert the exposed URI values.