Add config option to allowGitHooks#271
Open
carderne wants to merge 3 commits into
Open
Conversation
Programs that use the macOS system-configuration API (via SCDynamicStoreCreate) to read network proxy settings crash inside the sandbox because the mach-lookup to com.apple.SystemConfiguration.configd is blocked by default. This affects Rust programs using the system-configuration crate (e.g. uv, cargo) and other tools that query system proxy/network configuration on startup. The service is read-only — it exposes network configuration state (proxy settings, DNS servers, interface info) but cannot modify any system settings.
Add allowBrowserProcess option to the macOS sandbox profile. Chromium-based browsers require significantly broader OS permissions than typical CLI tools — Mach IPC for inter-process communication, bootstrap registration (Crashpad), process-info for managing renderer/GPU/utility child processes, IOKit for GPU and display access, and POSIX shared memory for renderer-GPU communication. The new option grants mach*, process-info*, iokit-open, and ipc-posix-shm* while keeping filesystem and network restrictions fully enforced. It is off by default and intended for use with browser automation tools like agent-browser. Updates sandbox-config schema, sandbox-manager wiring, macOS sandbox profile generation, and README documentation including security considerations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have
allowGitConfig, this adds a flag to allow writing to.git/hooks.Main reason to add this is that currently with the sandbox enabled, it's impossible to run
git init.More context in downstream issue here: carderne/pi-sandbox#44