chore: Re-design streaming services.#5276
Open
prmukherj wants to merge 11 commits into
Open
Conversation
Up to standards ✅🟢 Issues
|
Collaborator
|
@prmukherj Please make the description detailed so that reviewers know where to look and for what. |
Collaborator
Author
On it. |
prmukherj
marked this pull request as ready for review
July 21, 2026 12:30
mkundu1
approved these changes
Jul 21, 2026
Collaborator
General comments
|
seanpearsonuk
requested changes
Jul 21, 2026
seanpearsonuk
left a comment
Collaborator
There was a problem hiding this comment.
Initial comments from read through of _grpc_services.__init__.
Collaborator
There was a problem hiding this comment.
There's an inaccurate docstring regarding raw stubs:
class ServiceFactory:
"""Wraps raw gRPC stubs from ``GRPCServiceFactory`` in version-appropriate high-level service objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In previous PRs all the grpc services were properly segregated so that the low level grpc code remains in
_grpc_servicesand the high level python layer inservices. Now the streaming services also requires similar redesign. Moreover, there were instances ofserver_supports_v1leaking in the python codebase.Change Summary
_grpc_servicesand the high level python code instreaming_servicesserver_supports_v1in the PyFluent codebase.fluent_connection.service_factory.Rationale
This was done to provide a clean segregation to the PyFluent users, so that in future other services can be plugged in with minimal effort.
Impact
No impact to users.
All tests running fine.
Services covered in this refactoring: