Fixing _get_network_card issue with exahausting retry budget.#157
Open
joeysk2012 wants to merge 1 commit into
Open
Fixing _get_network_card issue with exahausting retry budget.#157joeysk2012 wants to merge 1 commit into
joeysk2012 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#153 attempted to fix a bug where network card is delayed from IMDS and incorrectly assigns the wrong metric to the ENI. This fix had a few issues after testing:
network_cardwas un-initialized therefore when.no-network-cardwas set, it ran into: unbound-variable error on line 559 when trying to echo it._get_network_cardexhausts retries, we used to mark.no-network-cardthis is not a stable signal because it's hard to tell if there is no network-card index other than 0, or just a propagation delay or garbage value. Instead we use .has-network-cards marker to either increase the retries or keep the retries to 40.Description of changes:
This PR initializes the network_card variable, increases the number of retires to 120ms when a non-zero network-card is detected and provides the marker
.has-network-cardsinstead of.no-network-card.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.