[new_profile] Fix non translated Project and Sites dropdowns #10847
Open
HachemJ wants to merge 1 commit into
Open
[new_profile] Fix non translated Project and Sites dropdowns #10847HachemJ wants to merge 1 commit into
HachemJ wants to merge 1 commit into
Conversation
ridz1208
reviewed
Jul 9, 2026
| $values, | ||
| 'ID' | ||
| ); | ||
|
|
Collaborator
There was a problem hiding this comment.
@driusan I feel like this is a step backwards for pselectColWithIndexKey() since we will end up looping through the data either way. is there a way to somehow centralize that to the DB class maybe?
like pselectColWithIndexKeyWithLocale() or it would be a mix of concerns ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR fixes the non translated Project and Sites dropdowns in the New Profile module by using the libraries (utility) functions
getProjectNamesandgetSiteNameListByIDsthat translate the values retrieved from the db.Testing instructions (if applicable)
Link(s) to related issue(s)