Skip to content

[new_profile] Fix non translated Project and Sites dropdowns #10847

Open
HachemJ wants to merge 1 commit into
aces:29.0-releasefrom
HachemJ:FixNotTranslatedProjectAndSitesDropdownsNewProfile
Open

[new_profile] Fix non translated Project and Sites dropdowns #10847
HachemJ wants to merge 1 commit into
aces:29.0-releasefrom
HachemJ:FixNotTranslatedProjectAndSitesDropdownsNewProfile

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR fixes the non translated Project and Sites dropdowns in the New Profile module by using the libraries (utility) functions getProjectNames and getSiteNameListByIDs that translate the values retrieved from the db.

Testing instructions (if applicable)

  1. Go to 'Candidate' -> 'New Profile'
  2. Switch the language to either 'French', 'Hindi' or 'Japanese' (the raisinbread locale languages so far)
  3. Verify that the Project and Sites dropdowns are translated in the language selected.
  4. (I think Optional) Try to add a new profile by filling the form using the new translated dropdowns and verify that it's working as expected.

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Module: new_profile PR or issue related to new_profile module labels Jul 8, 2026
@HachemJ HachemJ added Multilingual Any tasks related to making LORIS multilingual 29.0.0 - Bugs Issues found during the release testing for 29.0.0 labels Jul 8, 2026
$values,
'ID'
);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driusan I feel like this is a step backwards for pselectColWithIndexKey() since we will end up looping through the data either way. is there a way to somehow centralize that to the DB class maybe?

like pselectColWithIndexKeyWithLocale() or it would be a mix of concerns ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: PHP PR or issue that update PHP code Module: new_profile PR or issue related to new_profile module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants