Plugin directory: Prevent duplicated plugin submissions#698
Conversation
…ils both in the frontend and in the backend.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Plugin translations are imported automatically when it lands in trac. The best solution would be to allow imports only for PTEs. This prevents such activity on a permanent basis without disrupting legitimate activities. |
| } else { | ||
| $upload_result = $uploader->process_upload( $for_plugin ); | ||
| wp_cache_delete( $lock_key, 'wporg-plugins' ); | ||
| } |
There was a problem hiding this comment.
Is this strictly needed? Maybe we could try disabling the button first and see how it goes?
There was a problem hiding this comment.
For the feedback given I suspect that they think the process is stuck, they open a new window or reload the page and submit it again (while it is still processing), so yes, this would be needed.
Disabling the button is an additional just-in-case, but looks that the lock is the main thing.
There was a problem hiding this comment.
It wouldn't fail with a duplicate slug?
There was a problem hiding this comment.
It doesn't, when the duplicated submissions happen the system adds a number to the slug.
For example for a plugin under the name "PRT SEO" we receive prt-seo, prt-seo-2, prt-seo-3 and so on.
3 participants
Sometimes plugin authors inadvertently submit the same plugin multiple times; when spoken to, they explain that they thought the process had stalled and had tried to resubmit the form.
This adds two methods to prevent duplicated plugin submissions.