Skip to content

[codex] defer admin tour until compliance is ready#3324

Draft
xwil1 wants to merge 1 commit into
Wei-Shaw:mainfrom
xwil1:codex/defer-admin-tour-compliance
Draft

[codex] defer admin tour until compliance is ready#3324
xwil1 wants to merge 1 commit into
Wei-Shaw:mainfrom
xwil1:codex/defer-admin-tour-compliance

Conversation

@xwil1

@xwil1 xwil1 commented Jun 17, 2026

Copy link
Copy Markdown

Summary

  • defer the admin onboarding tour until admin compliance status has loaded
  • prevent the tour from starting while the compliance acknowledgement dialog is required
  • add regression coverage for first-login compliance gating

Root cause

The admin tour scheduled its auto-start as soon as AppLayout mounted. On first admin login, the compliance acknowledgement status is loaded asynchronously, so the tour could call drive(0) before the required compliance dialog finished.

Validation

  • cd frontend && ./node_modules/.bin/vitest run src/composables/__tests__/useOnboardingTour.spec.ts
  • cd frontend && ./node_modules/.bin/vue-tsc --noEmit
  • cd frontend && ./node_modules/.bin/eslint src/composables/useOnboardingTour.ts src/composables/__tests__/useOnboardingTour.spec.ts
  • git diff --check

Co-authored-by: Xvvln <180168103+Xvvln@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA. ✅
Posted by the CLA Assistant Lite bot.

@xwil1

xwil1 commented Jun 17, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Jun 17, 2026
@xwil1

xwil1 commented Jun 17, 2026

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant