Localized post dates to respect the publication language#174
Conversation
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThis change modifies two Handlebars templates, Estimated code review effort: 1 (Trivial) | ~3 minutes Sequence Diagram(s)No sequence diagram generated, as this change is a simple template text substitution with no control flow or interaction changes. Related issues: None specified. Related PRs: None specified. Suggested labels: none Suggested reviewers: none Poem: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
no issue - Post and post card dates were hardcoded to `DD MMM YYYY`, which ignores the site's publication language: only the month name was translated, leaving Western day-month-year ordering in every non-English locale - Dropped the explicit format so the `date` helper falls back to its locale-aware default (`ll`), rendering the whole date — order, separators and month name — according to the site's Publication Language - Left the machine-readable ISO value on the `datetime` attribute untouched
03115af to
0b6d1c6
Compare
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Post and post-card dates were hardcoded to
format="DD MMM YYYY", which ignoresthe site's Publication Language. Because only the month name is localized by the
datehelper, non-English sites got an awkward mix — e.g. a Korean site rendered04 7월 2026, keeping Western day-month-year ordering.Dropping the explicit format lets the
datehelper use its locale-aware default(
ll), so the whole date — ordering, separators and month name — follows thesite's Publication Language:
DD MMM YYYY){{date}}→ll)The machine-readable ISO value on the
datetimeattribute is unchanged.